go-env icon indicating copy to clipboard operation
go-env copied to clipboard
verified publisher icon Netflix

Remove Go minor revision specification

Open francesconi opened this issue 1 year ago • 3 comments

Specifying a Go minor revision forces all importers of the package to upgrade as well. Since I don't see any crucial benefit in enforcing this, I propose removing the requirement.

francesconi avatar Aug 09 '24 11:08 francesconi

Yes, please accept this PR. It is not the end of the world, but our CI is not yet updated to use Go 1.22.5 and this line causes an error due to this unnecessary requirement.

scottm-blackmagicdesign avatar Aug 20 '24 00:08 scottm-blackmagicdesign

@scottm-blackmagicdesign you can either upgrade to go 1.23 or temporarily add the following line to your go.mod file:

replace github.com/Netflix/go-env v0.0.1 => github.com/francesconi/go-env v0.0.0-20240809075706-245c4bde4d9a

francesconi avatar Aug 21 '24 06:08 francesconi

Thanks. We already have that, it just took me a little too long (😓) too understand why go mod tidy kept changing our Go language version to 1.22.5 after I had updated our dependencies. Go changed the requirements with 1.21+.

scottm-blackmagicdesign avatar Aug 22 '24 00:08 scottm-blackmagicdesign

Sorry for the trouble folks!

patricksanders avatar Aug 29 '24 20:08 patricksanders