falcor-http-datasource icon indicating copy to clipboard operation
falcor-http-datasource copied to clipboard

Published 20 hours ago • verified publisher icon Netflix

Errors: always use instance with status & all props from response

Open ajoslin opened this issue 8 years ago • 6 comments

This improves error handling:

  1. All error responses are mapped to an error object, but still have all properties of the error response from the server
  2. .status is always added to the error object.

ajoslin avatar May 23 '16 20:05 ajoslin

Great fix! I was about to implement it on my side... Hope it can be merged soon! It would fix https://github.com/Netflix/falcor/issues/745

synhaptein avatar Jun 29 '16 18:06 synhaptein

Hey guys, would be awesome to merge this, @ajoslin can you rebase your work against master maybe? Thx

gottfrois avatar Sep 01 '16 15:09 gottfrois

Hey! Just pinging for an update here?

Hagbarth avatar Oct 03 '16 14:10 Hagbarth

I'm not sure how to merge this with the latest changes safely, unfortunately, and I'm not currently active on the project I was using this in. I don't think I'll be able to justify taking the time to rebase it.

ajoslin avatar Oct 03 '16 20:10 ajoslin

@ajoslin Okay, how can I help?

Hagbarth avatar Oct 03 '16 21:10 Hagbarth

Thanks @Hagbarth -- we need to rebase this to the latest master and verify that it still works.

ajoslin avatar Oct 03 '16 22:10 ajoslin