ember-nf-graph icon indicating copy to clipboard operation
ember-nf-graph copied to clipboard

nf-graph should not disable user-select/drag for every element within

Open jayphelps opened this issue 10 years ago • 2 comments

Right now everything inside .nf-graph is made non-selectable/draggable. This prevents someone from easily copying numbers, labels, etc which I don't think was the intent.

.nf-graph * {
  user-select: none;
  user-drag: none;
}

https://github.com/Netflix/ember-nf-graph/blob/d74b0e533449f36aae680d8d19c12d44986ccd7e/styles/scss/components/nf-graph.scss#L16-L24

Instead, we should explicitly opt out things that should be selectable, Things like lines, paths, etc; if this is even necessary?

jayphelps avatar Jul 15 '15 19:07 jayphelps

Ah, this was done as an add for brush selection. Perhaps we need to dynamically set this when a brush component is on it?

It's tricky business. Maybe things that should be selectable need to opt back in?

benlesh avatar Jul 15 '15 20:07 benlesh

Your face is non-selectable/draggable, @jayphelps

benlesh avatar Mar 13 '24 16:03 benlesh