feat: update documentation for SSE subscriptions and update configura…

[Ancient-Dragon]

…tion documentation to include new configuration items.

[srinivasankavitha]

Thanks for the doc updates!

[srinivasankavitha]

Yes, but not the new graphql-ws. The older subscriptions-transport-ws is what is currently still in the framework.

On Tue, Jul 5, 2022 at 10:30 AM Ancient-Dragon @.***> wrote:

@.**** commented on this pull request.

In docs/advanced/subscriptions.md https://github.com/Netflix/dgs/pull/100#discussion_r914034521:

@@ -29,21 +29,30 @@ A complete example can be found [in SubscriptionDatafetcher.java](https://gith

The GraphQL specification doesn't specify a transport protocol. WebSockets are the most popular transport protocol however, and are supported by the DGS Framework. -Apollo defines a sub-protocol, which is supported by client libraries and implemented by the DGS framework. +Apollo defines a sub-protocol, which is supported by client libraries and implemented by the DGS framework.

Not sure what you mean here, I thought DGS supported websockets?

— Reply to this email directly, view it on GitHub https://github.com/Netflix/dgs/pull/100#discussion_r914034521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5JPXIVAXHZRHET264JF3DVSRWK7ANCNFSM52RCLJYQ . You are receiving this because you commented.Message ID: @.***>

[Ancient-Dragon]

Ah ak in which case I will update the documentation to make that clear and revert that change.

[Ancient-Dragon]

Done

[srinivasankavitha]

I just noticed this PR - the dgs framework actually implements a slightly different protocol based on https://github.com/CodeCommission/subscriptions-transport-sse