Adding missing tornado.port config

[eamonnfaherty]

trafficstars

[eamonnfaherty]

Sounds good to me. Happy to have you decide where to make the change. As a bit of feedback I found setting the config values a little difficult as there were many options. Thanks for the project though - I think it is pretty amazing so far.

On Fri, 17 Sep 2021, 06:20 Jay Dhulia, @.***> wrote:

@.**** commented on this pull request.

In docs/gitbook/quick-start/docker.md https://github.com/Netflix/consoleme/pull/9244#discussion_r710758508:

@@ -42,6 +42,9 @@ redis: global: consoleme-redis db: 0 port: 6379

Hi @eamonnfaherty https://github.com/eamonnfaherty! Thank you for the PR! The config variables you added here are actually part of the previous step. In that step, when you modify one of the example configs, or create a similar config to the example configs, it will include all relevant tornado configurations needed. For example, this https://github.com/Netflix/consoleme/blob/master/example_config/example_config_base.yaml base config includes relevant tornado settings here https://github.com/Netflix/consoleme/blob/master/example_config/example_config_base.yaml#L8-L14 . With that said, if it was confusing, maybe instead we can add some more clarifications to the previous step instead?

Also, for convenience, you can go to <consoleme_url>/generate_config to generate a config once you have ConsoleMe running in dev mode. For example, on the demo site, you can go to https://demo.consolemeoss.com/generate_config.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Netflix/consoleme/pull/9244#pullrequestreview-757071466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCZFQ5JLF3EAGDX5P4SOLUCLF3BANCNFSM5EEWHT2A .

[jaydhulia]

Hey @eamonnfaherty, apologies for the delay here. I think we can go ahead with making the first step more explicit:

1. Create a suitable configuration or use the samples provided in the repository here. Note that if you are creating your own config, or copying one of the sample configs, please make sure to include the required tornado config settings. Also, for convenience, you can go to <consoleme_url>/generate_config to generate a config once you have ConsoleMe running in dev mode. For example, on the demo site, you can go to https://demo.consolemeoss.com/generate_config.