conductor icon indicating copy to clipboard operation
conductor copied to clipboard

Specifying Task RetryCount in WorkflowTask instead of TaskDef

Open cquon opened this issue 6 years ago • 3 comments

Hi,

I think defining the retryCount on the WorkflowTask provides a more customizable way to fine tune tasks for a given workflow. There may be some workflows that want to retry the task x number of times, whereas other workflows do not even want to retry the task at all. By specifying the retryCount on the WorkflowTask instead of the TaskDef this can be achieved. Do you guys see any issues with this?

cquon avatar May 11 '18 17:05 cquon

i think it could be on both. A WorkflowTasks' retryCount can override TaskDefs' retryCount and if a WorkflowTask doesn't specify a retryCount , it could fallback to TaskDefs' retryCount

unikzforce avatar May 15 '18 22:05 unikzforce

Is it possible to assign retryCount for a workflow task dynamically at runtime?

jkaipa avatar Jan 31 '19 19:01 jkaipa

Thanks for the feedback and the suggestions. As @unikzforce mentioned,

A WorkflowTasks' retryCount can override TaskDefs' retryCount and if a WorkflowTask doesn't specify a retryCount , it could fallback to TaskDefs' retryCount

This gives the most configurable way to achieve this. Please feel free to submit a PR and we will be happy to review and merge.

apanicker-nflx avatar Mar 12 '19 01:03 apanicker-nflx