concurrency-limits icon indicating copy to clipboard operation
concurrency-limits copied to clipboard

Deprecate GradientLimit?

Open udaysagar2177 opened this issue 6 years ago • 0 comments

GradientLimit is very similar to Gradient2Limit except for few minor things and looks like GradientLimit needs some fixes, such as:

-            estimatedLimit = Math.max(minLimit, queueSize);
+            estimatedLimit = Math.max(minLimit, Math.min(maxLimit, queueSize));
...
-        newLimit = Math.max(queueSize, Math.min(maxLimit, newLimit));
+        newLimit = Math.max(minLimit, Math.min(maxLimit, newLimit));

And those from this PR: https://github.com/Netflix/concurrency-limits/pull/134.

With all these fixes, GradientLimit will be exactly equal to Gradient2Limit except for the probeInterval.

udaysagar2177 avatar Jul 10 '19 08:07 udaysagar2177