asgard
asgard copied to clipboard
Enable Metrics Collections setting not copied when using Manage Cluster of ASGs
When working with Manage Cluster of ASGs [1], the setting for enable metrics collection is not copied to the new autoscaling group.
For example, setting up a new autoscaling group (from asgard or from the cli), then running:
aws autoscaling enable-metrics-collection --auto-scaling-group-name example-asg --granularity 1Minute
Then using the Manage Cluster of ASGs to duplicate the ASG. The new ASG does not have this property set.
This is a very important metric that helps keep track of the history of the autoscaling group, and it would be great if asgard support it both when creating autoscaling groups , and when using manage cluster of ASGs.
[1] http://docs.aws.amazon.com/cli/latest/reference/autoscaling/enable-metrics-collection.html
There are a number of cases like this that have come up on the mailing list. I've created a PR for one such issue:
https://github.com/Netflix/asgard/pull/514
It is pretty easy to add the functionality to copy additional things, but there doesn't seem to be much enthusiasm on Netflix' part. Perhaps this isn't a useful feature for them or is actually an undesired change for some reason.
Could someone comment on this @aglover maybe? If wholesale copying isn't attractive, would making this configurable be more attractive? Say by specifying an ASG duplication strategy in config?
@e0d we're looking into this PR in particular. In general, AWS tags are unreliable -- from time to time they are not available. There are some ramifications w/r to their unreliability that we're considering.
Note: For this specific case, it's just a setting per ASG that should be added when duplicating an ASG, so there should not be any unreliability issues like when dealing with tags.
@t0mpson You are absolutely correct and I wasn't trying to hijack your issue. There are other things that are similar, but maybe less controversial than tags:
- Copying the public ip address config
- Copying the block device mappings
These use cases have also come up in the Google group. Public IP, plus metrics collection seems very straightforward to me.