asgard icon indicating copy to clipboard operation
asgard copied to clipboard

Published 20 hours ago • verified publisher icon Netflix

Environment variables should be configurable

Open paulbakker opened this issue 11 years ago • 4 comments

At several places in Asgard there are hard coded assumptions about what environment variables are available (countries, dev phase, partners etc.). These variables make sense for Netflix, but not for other users of Asgard. They should be configurable instead, for example in config.groovy.

Screen Shot 2013-03-02 at 14 35 18

paulbakker avatar Mar 02 '13 13:03 paulbakker

:+1:

I have the same need. The Netflix env variables mean nothing for me. I don't feel comfortable to use a PARTNER as a DATABASE_URL.

If I was able to configure the user data directly in the AutoScaling Group, e.g. in a textarea instead of a UserDataProvider class would be perfect. FTW

phstc avatar Mar 15 '13 02:03 phstc

I think all those funny hard-coded environment variables are not even really used at Netflix. It's a bunch of old legacy stuff and there are better ways of doing that.

I wonder if there could be a way to disable them entirely in the non-Netflix version of the code?

cquinn avatar Sep 21 '13 00:09 cquinn

If that is true then we should disable them even for Netflix. Can you give some specific examples?

claymccoy avatar Sep 21 '13 03:09 claymccoy

I'm referring to the Countries, Dev phase, Hardware devices, Partners and Revision encoded variables. From what I recall, those were an attempt to encode the groupings that some particular teams used in their clusters. What ended up being much more general and supported was the simple Stack notion. Are any of those other variables still used?

cquinn avatar Sep 21 '13 18:09 cquinn