Hystrix icon indicating copy to clipboard operation
Hystrix copied to clipboard

Changed ThreadPoolExecutor setCorePoolSize implementation on Java 10+ #1874

Open TimurD opened this issue 6 years ago • 6 comments

Call setMaximumPoolSize before setCorePoolSize to avoid a IllegalArgumentException exception.

TimurD avatar Oct 31 '18 17:10 TimurD

Looks like this solves #1874

andystanton avatar Nov 08 '18 14:11 andystanton

I just observed that if you are doing other way round then it would fail. Eg. This solution would work for increasing Thread pool size but if want to decrease thread pool size then it fails.

sachinvd avatar Jun 24 '19 15:06 sachinvd

I just observed that if you are doing other way round then it would fail. Eg. This solution would work for increasing Thread pool size but if want to decrease thread pool size then it fails.

Yeah, you are right. I have fixed it.

TimurD avatar Jun 26 '19 21:06 TimurD

Do we have any update on this issue . We cant move out of Hystrix right away and we are on Java 11.

umangsingh123 avatar Nov 04 '19 14:11 umangsingh123

Now I also set maximumPoolSize as a corePoolSize setting if corePoolSize is greater to avoid the exception.

TimurD avatar Nov 04 '19 19:11 TimurD

It looks like some problems with the project's licenses, but it is not related to my commit and I assume that it is fixed already in the latest version of the project.

TimurD avatar Nov 04 '19 19:11 TimurD