Hystrix icon indicating copy to clipboard operation
Hystrix copied to clipboard

Published 20 hours ago • verified publisher icon Netflix

metrics.rollingPercentile.enabled do not disable percentile calculation when set to false

Open akhitev opened this issue 6 years ago • 5 comments

The configuration property metrics.rollingPercentile.enabled do not disable anything when set to false. This seems to be changed since 1.5.x version.

akhitev avatar Jul 03 '18 17:07 akhitev

+1 Anything new about that?

pparth avatar Jul 04 '18 06:07 pparth

Could anyone from maintainers take a look at this, and confirm whether it is known bug, or we are missing something?

akhitev avatar Jul 12 '18 08:07 akhitev

I have prepared a fix for this. Could please someone take a look: https://github.com/Netflix/Hystrix/pull/1840

NZvereff avatar Aug 16 '18 09:08 NZvereff

+1 Anything new about that?

pparth avatar Oct 03 '18 08:10 pparth

Hi! Sorry to 'revive' such an old thread, but we are encountering issues realated to this... Not only is a quite big chunk of ram (75 MB aprox) going into latency metrics (even trying to get them disabled as per this issue), but this chunk is not being garbage collected on application (but not server) restarts... I see the PR was not merged in the end... @NZvereff did you manage to apply it successfully and ketp it in use in your case? Thanks!

mediocaballero avatar Feb 05 '21 08:02 mediocaballero