Fido icon indicating copy to clipboard operation
Fido copied to clipboard

Sorry but get disappointed to see this level of coding in NetFlix.

Open ocdogan opened this issue 9 years ago • 2 comments

In "Fido/Director/Director_Helper/The_Director_HostDetection.cs" source the line "if ((sHostname == null) && (sHostname == String.Empty))" in "HostDetection" method is buggy, the case is impossible to succeed.

Find one to review this project's codes. There are many bugs.

Leave using email as the error logger and find a cleaver way. Also leave using "Console" as the main trace environment.

ocdogan avatar Oct 03 '15 08:10 ocdogan

Not sure why they just didn't use String.IsNullOrEmpty(), especially considering they use it several times throughout that file anyway.

pcluddite avatar Feb 01 '16 22:02 pcluddite

Both of you should really read the comments from Robfry at https://github.com/Netflix/Fido/issues/16. If you checked that, you would see his response to why there are many bugs, the issues with licensing (i pointed out already it was copied from the stack overflow question), the lack of progress, and also his plans. Simple answer, he's working on it, but this is just a prototype.

Nothing bad about being worried or wanting to point out the problems with it, but this is most likely just scraps of code from all over. If it was working code, everyone would be worried, and if Netflix was using all of that code, I don't think they could use it. Just have to wait for the progress to start, and check back later.

dakre18 avatar Feb 16 '16 21:02 dakre18