Netanel Basal

icon indicating a website link https://www.netbasal.com

icon location Israel icon location A FrontEnd Tech Lead, blogger, and open source maintainer. The founder of ngneat, husband and father.

Results 277 comments of Netanel Basal

Add disallowIn config for web components and ShadowDOM

Maybe we can support web components and use `event.composedPath()[0]`

Add disallowIn config for web components and ShadowDOM

https://pm.dartus.fr/blog/a-complete-guide-on-shadow-dom-and-event-propagation/

Multi-language issues: check key code, instead of value

Do you want to create a PR?

Cannot get Spectator run with Angular 13 and Jest

I'm wondering why you're the only one mentioning this issue.

Cannot get Spectator run with Angular 13 and Jest

Can you reproduce on a fresh angular cli project, please?

feature(createRoutingFactory): Support use of DI prior to calling createRoutingFactory

What is the issue you are trying to resolve? Can you please reproduce it first?

Improve error message for not visible elements in tests

You're welcome to submit a PR.

fix: override providers for createComponentFactory

I don't think we need to use `resetTestingModule` for every provider. The issue is only when using `InjectionToken`, right?

fix: override providers for createComponentFactory

Now I'm not sure what's the issue. Works for me - https://github.com/ngneat/bind-query-params/blob/master/projects/ngneat/bind-query-params/src/lib/lib.spec.ts#L115

Spectator explicitly references "Jasmine" types breaking Jest tests

What is your suggestion?