NetSparkle icon indicating copy to clipboard operation
NetSparkle copied to clipboard

WIP: Support for Info.plist

Open mphill opened this issue 4 years ago • 4 comments

mphill avatar Jun 08 '20 11:06 mphill

@Deadpikle I need some guidance on how to handle the Company Name and constructor. This PR should allow me to start testing MacOS updates with Xamarin.

Thanks!

mphill avatar Jun 08 '20 11:06 mphill

For company name, you can either leave it blank, or we can document a special string that users can use to access it. NSUCompanyName or something (NSU = Net Sparkle Updater).

For the constructor, some refactoring needs to happen, which I need to find some time for here in the next few days. Thanks for your patience (and for another contribution)!

Deadpikle avatar Jun 10 '20 23:06 Deadpikle

@mphill Sorry for the wait. I just pushed a change to the develop branch that makes Configuration objects take an IAssemblyAccessor, which makes them much more configurable. You should be able to refactor things now -- an IAssemblyAccessor class that grabs data from Info.plist and a Configuration subclass that saves/loads to NSUserDefaults. Then users will be able to mix and match things for their use case, e.g. new SparkleUpdater(...) { new NSUserDefaultsConfiguration(new InfoPlistAccessor()) } or similar. This way, users can save and load to JSON if they want instead of NSUserDefaults.

As far as the company name for Info.plist: for now, returning CFBundleIdentifier if available makes the most sense to me.

Please ping me again when you've got things working and I'll try to be a little more on top of this PR. :)

Deadpikle avatar Jun 14 '20 15:06 Deadpikle

@mphill Any update?

Deadpikle avatar Nov 08 '20 17:11 Deadpikle

Closing due to lack of author response and not-needed-at-this-point Xamarin project.

Deadpikle avatar Nov 23 '23 11:11 Deadpikle