PowerUpSQL icon indicating copy to clipboard operation
PowerUpSQL copied to clipboard

Add params (MaxDepth and StopOnSysAdmin) and perf increases to Get-SQLServerLinkCrawl

Open MJVL opened this issue 3 years ago • 4 comments

This PR adds the following enhancements to Get-SQLServerLinkCrawl:

  • Performance increase
    • Crawling will no longer re-visit traversed links (same server with the same user)
    • This avoids circular dependencies, and cut down runtimes from days to a single hour in test environments with tens of servers, hundreds of links, and many circular links
    • Cuts down on noise and query amounts significantly
  • MaxDepth param
    • Allows for a max depth of the crawl, which can help to early exit in large environments
  • StopOnSysAdmin param
    • Stop crawl upon finding the first SysAdmin link

MJVL avatar Sep 01 '22 01:09 MJVL

Great additions! Resolving circular dependencies is very important, as infinite loops can take cause performance issues on target systems.

v-p-b avatar Dec 03 '22 08:12 v-p-b

Im sorry it took me so long to see this. I'll try to review your updates in the next few weeks. Superficially they look great. Thank you for taking the time to submit the features/fixes!

nullbind avatar Dec 24 '22 04:12 nullbind

Im sorry it took me so long to see this. I'll try to review your updates in the next few weeks. Superficially they look great. Thank you for taking the time to submit the features/fixes!

Coming back to this after forgetting about it for a while. Is this still good to review/merge?

MJVL avatar Jul 19 '24 02:07 MJVL