trident icon indicating copy to clipboard operation
trident copied to clipboard

Use fully qualified domain image names by default (docker.io)

Open spiarh opened this issue 3 years ago • 1 comments

Change description

It is more and more common that Container Runtimes do not resolve unqualified image names to docker.io for various reason.

Setting docker.io/ prefix by default does not change the behavior at all but makes the life much easier for teams managing trident on clusters without unqaulified image name resolution.

Did you add unit tests? Why not?

Already covered in utils_test.go

Does this code need functional testing?

Minor change that don't change anything

Is a code review walkthrough needed? why or why not?

I don't think so, there is no logic added at all :smile:

Does this code need a note in the changelog?

yes

Does this code require documentation changes?

no, users don't have anything to change or to understand with this change.

Did you add unit tests? Why not?

Already covered in utils_test.go

Does this code need functional testing?

Minor change that don't change anything

Is a code review walkthrough needed? why or why not?

I don't think so, there is no logic :smile:

Does this code need a note in the changelog?

yes

Does this code require documentation changes?

no, users don't have anything to change or to understand with this change.

spiarh avatar Jan 13 '22 17:01 spiarh

Hi @spiarh,

Have you submitted a CCLA as indicated in the contributing guidelines?

gnarl avatar Mar 18 '22 21:03 gnarl