NetApp
Fix: issue into helm template and helm helper
Change description
Fixed two helm issues, the first one is about format of cloudProvider and cloudIdentity, the second one is about comment into helm template
Project tracking
N/A
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
N/A
Does this code need functional testing?
N/A
Is a code review walkthrough needed? why or why not?
Yes, but as I'm an external developer, not sure who I'd ask
Should additional test coverage be executed in addition to pre-merge?
Don't think so as helm templates fine
Does this code need a note in the changelog?
Mo
Does this code require documentation changes?
No
Additional Information
These changes prevent the errors: Error: YAML parse error on trident-operator/templates/tridentorchestrator.yaml: error converting YAML to JSON: yaml: line 31: mapping values are not allowed in this context helm.go:84: [debug] error converting YAML to JSON: yaml: line 31: mapping values are not allowed in this context YAML parse error on trident-operator/templates/tridentorchestrator.yaml helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146 helm.sh/helm/v3/pkg/releaseutil.SortManifests helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106 helm.sh/helm/v3/pkg/action.(*Configuration).renderResources helm.sh/helm/v3/pkg/action/action.go:168 helm.sh/helm/v3/pkg/action.(*Install).RunWithContext helm.sh/helm/v3/pkg/action/install.go:304 main.runInstall helm.sh/helm/v3/cmd/helm/install.go:306 main.newTemplateCmd.func2 helm.sh/helm/v3/cmd/helm/template.go:95 github.com/spf13/cobra.(*Command).execute github.com/spf13/[email protected]/command.go:940 github.com/spf13/cobra.(*Command).ExecuteC github.com/spf13/[email protected]/command.go:1068 github.com/spf13/cobra.(*Command).Execute github.com/spf13/[email protected]/command.go:992 main.main helm.sh/helm/v3/cmd/helm/helm.go:83 runtime.main runtime/proc.go:250 runtime.goexit runtime/asm_amd64.s:1598
and: Warning, the generated YAML may contain parsing errors. Converting it to JSON failed: error converting YAML to JSON: yaml: line 49: mapping values are not allowed in this context
