harvest icon indicating copy to clipboard operation
harvest copied to clipboard

Add descriptions to all Harvest dashboard panels and remove Drilldown from rows

Open cgrinds opened this issue 2 years ago • 4 comments

  • [ ] Add descriptions to dashboard panels
  • [x] Remove the word Drilldown from dashboards row

cgrinds avatar Feb 23 '23 20:02 cgrinds

Here, 2 categories are still pending which don't have panel description.

  1. Panel has complex query expression (56 panels)
  2. Panel has multiple queries (81 panels)

Hardikl avatar Mar 15 '24 14:03 Hardikl

Missing panel description in SVM dashboard: Out of 47 panels, 9 panels are histogram

    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM Average Latency" has many expressions 1
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM Throughput" has many expressions 2
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM IOPs" has many expressions 3
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM CIFS Latency" has many expressions 4
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM FCP Average Latency" has many expressions 5
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM FCP Throughput" has many expressions 6
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM FCP IOPs" has many expressions 7
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM iSCSI Average Latency" has many expressions 8
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM iSCSI Throughput" has many expressions 9
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv3 SVMs by Read and Write Latency" has many expressions 10
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv3 SVMs by Throughput" has many expressions 11
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv3 SVMs by IOPs" has many expressions 12
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv3 Latency by Op Type" has many expressions 13
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv3 IOPs per Type" has many expressions 14
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4 SVMs by Read and Write Latency" has many expressions 15
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4 SVMs by Throughput" has many expressions 16
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4 SVMs by IOPs" has many expressions 17
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4 Latency by Op Type" has many expressions 18
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4 IOPs per Type" has many expressions 19
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.1 SVMs by Read and Write Latency" has many expressions 20
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.1 SVMs by Throughput" has many expressions 21
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.1 SVMs by IOPs" has many expressions 22
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4.1 Latency by Op Type" has many expressions 23
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4.1 IOPs per Type" has many expressions 24
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.2 SVMs by Read and Write Latency" has many expressions 25
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.2 SVMs by Throughput" has many expressions 26
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources NFSv4.2 SVMs by IOPs" has many expressions 27
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4.2 Latency by Op Type" has many expressions 28
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="NFSv4.2 IOPs per Type" has many expressions 29
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="SVM NVMe/FC Throughput" has many expressions 30
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM NVMe/FC Average Latency" has many expressions 31
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM NVMe/FC Throughput" has many expressions 32
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="SVM NVMe/FC IOPs" has many expressions 33
    dashboard_test.go:1502: dashboard=cmode/svm.json panel="Copy Manager Requests" has many expressions 34
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources SVMs by QoS Latency" has many expressions 35
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources SVMs by QoS Throughput" has many expressions 36
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Top $TopResources SVMs by QoS IOPs" has many expressions 37
    dashboard_test.go:1511: dashboard=cmode/svm.json panel="Qos Sequential Reads and Writes (%)" has many expressions 38
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv3 Latency Heatmap" does not have panel description 39
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv3 Read Latency Heatmap" does not have panel description 40
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv3 Write Latency Heatmap" does not have panel description 41
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4 Latency Heatmap" does not have panel description 42
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4 Read Latency Heatmap" does not have panel description 43
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4 Write Latency Heatmap" does not have panel description 44
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4.1 Latency Heatmap" does not have panel description 45
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4.1 Read Latency Heatmap" does not have panel description 46
    dashboard_test.go:1506: dashboard=cmode/svm.json panel="NFSv4.1 Write Latency Heatmap" does not have panel description 47

Missing panel description in Volume dashboard:

    dashboard_test.go:1506: dashboard=cmode/volume.json panel="Volume Latency by Op Type" does not have panel description 1
    dashboard_test.go:1506: dashboard=cmode/volume.json panel="Volume IOPs per Type" does not have panel description 2
    dashboard_test.go:1506: dashboard=cmode/volume.json panel="Top $TopResources Volumes by Number of Compress Attempts" does not have panel description 3
    dashboard_test.go:1506: dashboard=cmode/volume.json panel="Top $TopResources Volumes by Number of Compress Fail" does not have panel description 4

Hardikl avatar Apr 29 '24 11:04 Hardikl

With PR 2861 changes, Missing panel description in SVM dashboard:

    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv3 Latency by Op Type" has arithmetic operations 1
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv3 IOPs per Type" has arithmetic operations 2
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4 Latency by Op Type" has arithmetic operations 3
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4 IOPs per Type" has arithmetic operations 4
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4.1 Latency by Op Type" has arithmetic operations 5
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4.1 IOPs per Type" has arithmetic operations 6
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4.2 Latency by Op Type" has arithmetic operations 7
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="NFSv4.2 IOPs per Type" has arithmetic operations 8
    dashboard_test.go:1503: dashboard=cmode/svm.json panel="Copy Manager Requests" has arithmetic operations 9

Missing panel description in Volume dashboard:

    dashboard_test.go:1507: dashboard=cmode/volume.json panel="Volume Latency by Op Type" does not have panel description 1
    dashboard_test.go:1507: dashboard=cmode/volume.json panel="Volume IOPs per Type" does not have panel description 2
    dashboard_test.go:1507: dashboard=cmode/volume.json panel="Top $TopResources Volumes by Number of Compress Attempts" does not have panel description 3
    dashboard_test.go:1507: dashboard=cmode/volume.json panel="Top $TopResources Volumes by Number of Compress Fail" does not have panel description 4

Hardikl avatar Apr 30 '24 10:04 Hardikl

With this PR changes, only few exceptions panels and panels with arithmetic expressions are pending.

Hardikl avatar May 06 '24 15:05 Hardikl

covered by unit tests. Moving to done.

rahulguptajss avatar May 14 '24 14:05 rahulguptajss