FragPipe icon indicating copy to clipboard operation
FragPipe copied to clipboard

ALL FragmentLossType apparently NaN

Open JM-Bader opened this issue 2 years ago • 8 comments

Hi, i would like to use MSFragger to generate a library from DDA PASEF data for a subsequent diaPASEF search with DIA-NN. Overall, this works. However, when looking at the library outputted by fragpipe running MSFragger, it is striking that all entries in FragmentLossType are NaN. This came up as DIA-NN raised an alarm and I was first in touch with Demichev. He said that DIA-NN treats NaN as no loss by default, so it is possible to run though. However, that clearly isn't ideal as some of these entries very likely have a neutral loss.

My Library: image

MSFragger settings in fragpipe: image image

general fragpipe version etc.: image

Q1: What causes the issue? Q2: How to fix it? (ie. get the library with relevant FragmentLossType information)

JM-Bader avatar May 12 '22 14:05 JM-Bader

I have just replied it on DIA-NN's repo. Please find it here https://github.com/vdemichev/DiaNN/discussions/377#discussioncomment-2738436.

In a word, we will add it in the future.

Best,

Fengchao

fcyu avatar May 12 '22 14:05 fcyu

Following is the code from Vadim (https://github.com/vdemichev/DiaNN/discussions/377#discussioncomment-2738553):

if (wl == "noloss") p.loss = loss_none;
									else if (wl == "H2O") p.loss = loss_H2O;
									else if (wl == "NH3") p.loss = loss_NH3;
									else if (wl == "CO") p.loss = loss_CO;
									else if (wl == "H3PO4") p.loss = loss_H3PO4;
									else if (wl == "H4COS") p.loss = loss_H4COS;
									else p.loss = loss_other;

Hi @guoci , we need to add checkboxes in the spectral library generation tab to support neutral loss. I can change the FragPipe part, but need your help to change the Python script and EasyPQP.

Best,

Fengchao

fcyu avatar May 12 '22 14:05 fcyu

How does setting 'Deneutralloss' to NO impact this ? (e.g. in the new version 18.0)? image Is neutral loss information available there now?

JM-Bader avatar Jun 02 '22 15:06 JM-Bader

Setting it to "No" might result in worse identification result. It is used in MSFragger database searching. Not for spectral library building.

Best,

Fengchao

fcyu avatar Jun 02 '22 15:06 fcyu

Thanks for the swift reply. So the new version 18.0 that just came out does not yet support neutral loss specification for libraries (independent from the 'Deneutralloss' button), correct?

JM-Bader avatar Jun 02 '22 15:06 JM-Bader

Correct. Writing neutral loss info to the spectral library is not yet supported. We will implement it in the near future.

Best,

Fengchao

fcyu avatar Jun 02 '22 15:06 fcyu

JM-Bader: If you contact us directly (e.g. email me), I want to understand your interest in the neutral losses. Just regular -18/-17 are not likely to be that useful, I think. We will add them, though.

@.***>Guo Ci: can you add an option to write neutral losses in the library. It is already in EasyPQP we just need to propagate that option to FragPipe. And we need to check the format, if the new column as written by EasyPQP is compatible with 1.8.1. If not, we will email Vadim (or will need to change to DAI-NN format)

Alexey

From: JM-Bader @.> Sent: Thursday, June 2, 2022 11:30 AM To: Nesvilab/FragPipe @.> Cc: Subscribed @.***> Subject: Re: [Nesvilab/FragPipe] ALL FragmentLossType apparently NaN (Issue #677)

External Email - Use Caution

Thanks for the swift reply. So the new version 18.0 that just came out does not yet support neutral loss specification for libraries (independent from the 'Deneutralloss' button), correct?

— Reply to this email directly, view it on GitHubhttps://github.com/Nesvilab/FragPipe/issues/677#issuecomment-1145000170, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIMM63BLHTX4G2WZGCTVF3VNDHRFANCNFSM5VYOREJA. You are receiving this because you are subscribed to this thread.Message ID: @.@.>>


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

anesvi avatar Jun 02 '22 15:06 anesvi

The format/string that can be recognized by DIA-NN is as following.

Best,

Fengchao

Following is the code from Vadim (vdemichev/DiaNN#377 (reply in thread)):

if (wl == "noloss") p.loss = loss_none;
									else if (wl == "H2O") p.loss = loss_H2O;
									else if (wl == "NH3") p.loss = loss_NH3;
									else if (wl == "CO") p.loss = loss_CO;
									else if (wl == "H3PO4") p.loss = loss_H3PO4;
									else if (wl == "H4COS") p.loss = loss_H4COS;
									else p.loss = loss_other;

Hi @guoci , we need to add checkboxes in the spectral library generation tab to support neutral loss. I can change the FragPipe part, but need your help to change the Python script and EasyPQP.

Best,

Fengchao

fcyu avatar Jun 02 '22 15:06 fcyu