OneTrainer icon indicating copy to clipboard operation
OneTrainer copied to clipboard

[Feat]: Dataset masking UI should display a brush outline matching current brush size

Open O-J1 opened this issue 1 year ago • 2 comments

Describe your use-case.

Dataset masking UI should display a brush outline matching current brush size. Low prio but also likely relatively easy.

What would you like to see as a solution?

A thin circular outline that changes after the user scrolls, matching the current brush size.

Have you considered alternatives? List them here.

N/A

O-J1 avatar Nov 17 '24 08:11 O-J1

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

Arcitec avatar Nov 18 '24 20:11 Arcitec

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

Yep, this is just a transferred user request opened on behalf of them. Made a quick n dirty POC and it worked but was not upstreamable

O-J1 avatar Nov 19 '24 02:11 O-J1

Closing my own issue as its sadly not really possible to do this without a huge amount of GUI lag.

O-J1 avatar Oct 12 '25 09:10 O-J1