OneTrainer icon indicating copy to clipboard operation
OneTrainer copied to clipboard

[Bug]: Flux DoRas do not work with full layer preset

Open ejektaflex opened this issue 1 year ago • 2 comments

What happened?

I've described it in this issue for ComfyUI (https://github.com/comfyanonymous/ComfyUI/issues/4695#issuecomment-2326417622), but it seems as though DoRas do not work properly in Comfy and they've implied it might have to do with the format of the file.

What did you expect would happen?

I would expect there to be no pink noise introduced when creating and using a DoRa instead of a LoRa. LoRas look fine.

Relevant log output

No response

Output of pip freeze

No response

ejektaflex avatar Sep 03 '24 14:09 ejektaflex

It seems to be that a DoRa made using only the attn preset works, but using the full layers preset does not work, causing the pink artifacts.

ejektaflex avatar Sep 05 '24 07:09 ejektaflex

I'd like to help fix this issue, is it something to be changed on Comfy or on OneTrainer? No idea where to start lol

2snEM6 avatar Sep 19 '24 15:09 2snEM6

According to comfy this should be fixed now. Can you confirm, or do you still see the problem?

Nerogar avatar Oct 15 '24 20:10 Nerogar

I have tested a full Flux Dora in Comfy and it works now. It still creates the pink coloration in Forge.

Calamdor avatar Oct 15 '24 20:10 Calamdor

Great, thanks. That confirms it's not a OneTrainer issue

Nerogar avatar Oct 15 '24 20:10 Nerogar