grafana-cal-heatmap-panel icon indicating copy to clipboard operation
grafana-cal-heatmap-panel copied to clipboard

Published 20 hours ago • verified publisher icon NeoCat

Jagged Edges

Open mattttt opened this issue 8 years ago • 1 comments

Hi! Really enjoying this plugin, started playing around with it as an outage calendar to be used in conjunction with worldPing.

Noticed that when increasing the cell radius, the edges get pretty jagged - but ironically, shape-rendering: crispedges; makes it jagged:

crispedges

https://github.com/NeoCat/grafana-cal-heatmap-panel/blob/master/src/bower_components/cal-heatmap/cal-heatmap.css#L19

Before submitted a PR to remove it, is there another scenario where that's required? When configured to be squares (cell radius 0), it seemed to make no difference.

mattttt avatar Dec 08 '16 22:12 mattttt

This is from an default option of cal-heatmap.js which has been specified at the very first version committed to GitHub, so I couldn't track down why this is added. In my opinion, it is okey to be overridden by this plugin if it won't obviously break something.

NeoCat avatar Dec 10 '16 10:12 NeoCat