Neo-Store icon indicating copy to clipboard operation
Neo-Store copied to clipboard

Neo Store cannot update itself

Open Prodigalmanboy opened this issue 1 year ago • 35 comments

I just started using Neo Store at version 1.00. In the subsequent two new versions, 1.01, and 1.02, I have observed that Neo Store cannot update itself to the newer version. It appears to download, but then simply stops. One has to install F-Droid in order to update Neo Store.

Android 13 on Pixel 8.

This issue is also observed on two other Xiaomi phones I use.

Expected behavior - Neo Store should not require another app to update; it should be able to update itself.

Prodigalmanboy avatar May 20 '24 05:05 Prodigalmanboy

That should be Android 14 on Pixel 8, not Android 13.

Xiaomi phones are Redmi Note 11s, running Lineage OS 13, and Evolution X 13.

Prodigalmanboy avatar May 20 '24 05:05 Prodigalmanboy

I guess you have the download stuck or something in that direction (try deleting the item in the downloaded list and sync) … Here's some needed information:

  • Did you disable battery optimization for NS?
  • Is the auto-update enabled?
  • Did other apps get updated?
  • What is your selected installer?

machiav3lli avatar May 20 '24 08:05 machiav3lli

Thank you for replying.

I did delete the downloaded update; rebooted, with no luck. However, I did not try to re-sync because the new version showed as available (manual install), and or immediately attempted to download and install. No joy.

  1. Yes, battery optimization is disabled for Neo Store.
  2. It would not update under auto-update, or under manual.
  3. Other apps update fine.
  4. I only used the root installer on all devices.

Prodigalmanboy avatar May 20 '24 11:05 Prodigalmanboy

Can you try installing the latest version through tapping the install button on the suggested version at the bottom of the app sheet?

machiav3lli avatar May 21 '24 09:05 machiav3lli

@machiav3lli ~~Found the bug. I navigated to the folder where Neo Store caches the downloaded APKs. The APK was incorrectly downloaded/corrupted in some manner. Tapping on it caused the "There was a problem parsing this package" dialogue.~~

~~The APK can be deleted manually or by clearing the cache. But re-downloading keeps giving the same broken APK.~~

^ Incorrect. See: https://github.com/NeoApplications/Neo-Store/issues/614#issuecomment-2143779944.

I'm trying to update from 1.0.1 -> 1.0.2. Didn't face this bug in previous updates.

BTW, the rest of the apps download and update just fine, though this is the same repo index update cycle. ~~It is only Neo Store itself which has a corrupt APK when self-downloading. Also, APKs downloaded from Github and F-Droid's website are parsed perfectly fine.~~

On a hunch, tried toggling the System download manager off and on. That didn't work. This happened on multiple devices so the bug is surely in Neo Store.

opusforlife2 avatar May 24 '24 04:05 opusforlife2

@machiav3lli Do you want to do any tests? I'm still on 1.0.1 just in case you do.

opusforlife2 avatar May 31 '24 08:05 opusforlife2

@opusforlife2 using system download manager or the default downloader?

machiav3lli avatar May 31 '24 22:05 machiav3lli

On a hunch, tried toggling the System download manager off and on. That didn't work.

^

I normally use system, not default. But this bug seems to be occurring for both.

opusforlife2 avatar Jun 01 '24 06:06 opusforlife2

Update: Apparently, the non-parsable APK in the cache folder wasn't necessarily broken, because ALL APKs seem to be in the same state, even if the apps/updates install successfully.

So Neo Store is simply not carrying out the install step for some reason. I also tried this with the default session installer.

Edit: Also, this bug is a bit random, because it is happening on two devices with LOS 21, but not on two others, also with the exact same OS and general settings.

opusforlife2 avatar Jun 02 '24 09:06 opusforlife2

I am experiencing this issue on every device on which I happened to upgrade to version 1.0.1. Upgrading to version 1.0.2 does not seem to fix it. I used a different F-Droid client to upgrade Neo Store and then told Neo Store to reinstall itself. On other devices upon which I upgraded directly from Neo Store 1.0.0 to 1.0.2, the issue did not occur, and Neo Store 1.0.2 reinstalled itself when requested. All devices were running LineageOS 21 or 20 and the root session installer method.

crystalcommunication avatar Jun 04 '24 02:06 crystalcommunication

@machiav3lli Any other tests?

opusforlife2 avatar Jun 17 '24 07:06 opusforlife2

Welp, this seems to have turned into a permanent problem. I can't update from 1.0.2 to 1.0.3 either.

opusforlife2 avatar Jul 09 '24 19:07 opusforlife2

Neo Store still will not itself update 1.02 to 1.03, or 1.04. Still need F-droid to do it.

Prodigalmanboy avatar Jul 09 '24 22:07 Prodigalmanboy

Nor will Neo Store 1.03 update to 1.04.

Prodigalmanboy avatar Jul 09 '24 22:07 Prodigalmanboy

Hm, I guess, I'll have to check if Android had any API-changes that would cause this.

machiav3lli avatar Jul 10 '24 13:07 machiav3lli

I have been messing with this issue on several devices.

Here is what I found on an Huawei MediaTab T5 Android 9 system that is NOT rooted:

The install program is "looping" ... in other words you tap "install" and it immediately loops the installer back to the prompt to install the update. In frustration I just kept hammering "install" and it eventually installed after about 40+ attempts. Not sure this will help with the issue, but I can repeat it at will on the T5 tablet. To me, it is likely something similar happening in later versions of Android, but you just do not see it if you are using the root installer.

Prodigalmanboy avatar Jul 12 '24 03:07 Prodigalmanboy

If you use the new android api, you can only update apps in the background which where installed or updated once with the third party store. Maybe that causes a problem?

yoshimo avatar Jul 12 '24 05:07 yoshimo

Nor will Neo Store 1.03 update to 1.04.

Try clearing storage for Neo Store. You'll need to set up your settings and repos again.

If you use the new android api, you can only update apps in the background which where installed or updated once with the third party store. Maybe that causes a problem?

Isn't that already implemented as the auto-updater for Android 13+?

crystalcommunication avatar Jul 17 '24 03:07 crystalcommunication

it is used but I haven't tried older versions of neo store on older OS versions to see when exactly this bug appeared.

yoshimo avatar Jul 17 '24 07:07 yoshimo

Update: I can't believe this occurred to me to try only now. I simply copied the APK downloaded by Neo Store and put it in my downloads folder. Then installing it worked. So the APK itself is definitely fine. Neo Store is just not going ahead with the installation for some reason.

opusforlife2 avatar Jul 17 '24 07:07 opusforlife2

Yeah, as suggested earlier it's nothing fundamental with the apks, rather maybe some API changes or funny interactions between using the different installers.

So to test the second point: How does it look on the installers' side? Were different installers used in different versions e.g. root till 1.0.1 then session on later? What are the tested installers of this issue?

machiav3lli avatar Jul 18 '24 23:07 machiav3lli

Good idea. The root installer bug caused me to switch to default. I'll test with root on the next update.

opusforlife2 avatar Jul 19 '24 05:07 opusforlife2

I switched to the root installer when it was released, and it wouldn't install the downloaded Neo Store v1.0.4 APK from v1.0.3, I had to install it manually. Thanks

KaKi87 avatar Jul 19 '24 11:07 KaKi87

Neither session, nor root installer has worked for me ever, but I only started using Neo Store at 1.01.

I have gone back as far as Android 8 and it it still has the issue. 1.04 will not update to 1.05 unless manually installed, or updated by F-Droid etc.

Prodigalmanboy avatar Jul 19 '24 21:07 Prodigalmanboy

but I only started using Neo Store at 1.01

That's when the bug was introduced. The 1.0.0 -> 1.0.1 update worked fine.

opusforlife2 avatar Jul 19 '24 21:07 opusforlife2

I am using the root installer and it can't update. Just failed again for the 1. 04 - >1.05 Update like the two previous ones.

yoshimo avatar Jul 26 '24 04:07 yoshimo

I cleared data for Neo Store in version 1.0.3 and it has updated itself to 1.0.4 and 1.0.5 okay since then.

crystalcommunication avatar Aug 21 '24 21:08 crystalcommunication

Is this fixed now? Can neo store update itself automatically now?

amano-kenji avatar Jan 09 '25 02:01 amano-kenji

Well, there haven't been an update in a while, so we'll know next time it happens

KaKi87 avatar Jan 09 '25 02:01 KaKi87

It seems to me that this issue must be solved by operating system. I think GrapheneOS refuses to let neo start update itself for security. If security was so important, then GrapheneOS should let me pick a list of programs that can update themselves. Android should let me do so, too.

amano-kenji avatar Jan 09 '25 10:01 amano-kenji