Some apps show up with a generic icon

[bt90]

The fallback is correct for Transistor which doesn't provide an icon. Syncthing-Fork has a proper icon but it isn't used.

https://f-droid.org/en/packages/com.github.catfriend1.syncthingandroid/

[machiav3lli]

A lot of apps still don't respect modern metdata requirements and thus their icons are left out or a they should be aggregated from some others places (which have many negative sides regarding security, performance etc..). To solve this, just write each project on the fact that metdata requirements say that the project's icon should be available in the main locale (e.g. en-US) under /images with the name icon.png

[bt90]

According to one of the jitsi devs, adaptive icons are not supported yet.

https://github.com/jitsi/jitsi-meet/issues/12019#issuecomment-1214320226

[bt90]

@machiav3lli does Neo-Store support adaptive icons?

[machiav3lli]

As long as FDroid doesn't we don't

[bt90]

@machiav3lli i'm currently investigating for https://github.com/Catfriend1/syncthing-android/issues/904 and all icons seem to be where they belong?

https://github.com/Catfriend1/syncthing-android/blob/b921e1a2cbf63dde0bb3c2a9b800e9755cc4a97d/app/src/main/AndroidManifest.xml#L43

e.g https://github.com/Catfriend1/syncthing-android/blob/main/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png

The original f-droid client does in fact display an icon for the app.

Edit: the play listing also provides an icon:

https://github.com/Catfriend1/syncthing-android/tree/main/app%2Fsrc%2Fmain%2Fplay%2Flistings%2Fen-GB%2Fgraphics%2Ficon

[leoheitmannruiz]

@bt90 In case you're interested and for the sake of completeness: the only way to provide an icon for an app in the main F-Droid repository is using Fastlane/Triple-T metadata in the source code repository of the app. See https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/.

What seemingly caused confusion here is that Neo Store only checks the en-US locale for the icon (and presumably other metadata). en-US is the default locale in the F-Droid ecosystem and all apps should provide metadata in en-US.

Syncthing-Fork didn't provide the icon in en-US but in en-GB. I recently sent a PR moving the metadata to en-US, which was merged: https://github.com/Catfriend1/syncthing-android/pull/1182. You should now see the icon and screenshots :)

The official F-Droid client and f-droid.org also check en-GB and plain en for metadata. That's why the official client and website showed an icon, but Neo Store didn't.

Edit: I think I was not quite right. I'm pretty sure f-droid.org is fine with en and en-* and the official client might be too, but I'm a lot less sure. It's definitely fine with en, en-AU, en-GB, and en-US so assume it's fine with en-*.

[machiav3lli]

@leoheitmannruiz thanks for the insights. I should be able to patch things up for next release

[leoheitmannruiz]

For the record: I'm not convinced that additionally checking en and en-GB is a good idea for Neo Store. The whole metadata and locale situation at F-Droid is sadly a little wishy-washy, I find. en-US is the default locale, but then en and en-GB are also checked, but en-US is preferred.

I think I'd like the F-Droid project to commit to either: "en-US is the default locale, all apps have to use it" and update the behavior of their client and their website or "en, en-GB, and en-US are fine, all apps have to use one of them".

I'm definitely not sure though.

I've been wanting to open an issue about this for some time now. I think I'll do so later today or tomorrow. Perhaps you want to wait until I have a response? I'll gladly keep you updated.

Edit: Please see the edit in my previous comment.