Neo-Store icon indicating copy to clipboard operation
Neo-Store copied to clipboard

Repository index parsing failure isn't helpful

Open MTRNord opened this issue 3 years ago • 6 comments
trafficstars

Hi, I am the maintainer of the Fluffychat Repository at https://nightly.fdroid.fluffychat.im/index-v1.json

This repo works fine with the official fdroid app, however we got a report that neostore reports this as invalid.

As you may see this is a rather huge nightly repo with around 1305 releases in one app alone (Fluffychat).

Neostore doesn't give me any indications what's wrong with it apart from saying that it is incorrect, and other fdroid apps work fine with this. So it would be great if someone can help me to make it work with this store as well. The index is generated using the fdroid update command of fdroidserver. So it's a rather standard setup.

I would love to find a solution to this if someone can give me some indications or try to debug it :)

MTRNord avatar May 21 '22 11:05 MTRNord

I guess releases' number is the issue here… if you've already looked into the code, you'll see that Release objects are included (in a list form) in Product which is saved in a Room-DB. I didn't consider this amount of kept releases for one app, which may be the issue. A DB refactoring is planned between v0.9 and v1, which would solve this issue.

machiav3lli avatar May 31 '22 07:05 machiav3lli

Ah ok :)

Yeah this is just a push and forget nightly repo. So we have a release basically in every commit with this. 😅

MTRNord avatar May 31 '22 08:05 MTRNord

So a fix for now would'be to set a reasonable upper limit (this is also good for sustainability reasons ;-) )

machiav3lli avatar May 31 '22 10:05 machiav3lli

git_mirror_size_limit might help?

Efreak avatar Jun 27 '22 00:06 Efreak

Hey @Efreak, nope, it's not about the repo size, it's about the size of the field Releases in the object Product

machiav3lli avatar Jun 29 '22 06:06 machiav3lli

A smaller repo will have fewer releases in it. If the smaller mirror is used in place of the main repo, it might fix your issue. (I'm not sure if the mirrors contain metadata for releases they don't include)

Is there a reason moving old releases to the archive doesn't work?

Efreak avatar Jun 29 '22 20:06 Efreak