Neo-Launcher icon indicating copy to clipboard operation
Neo-Launcher copied to clipboard

Updating an app causes the app icon to reset to the system's default one

Open MatsG23 opened this issue 3 years ago • 11 comments

Description

When I update any app, the app logo/icon in the launcher changes to the default Android one. This issue does not occur in the standard launcher (here: GrapheneOS launcher3).

Expected Behavior

The app icon should update to the one packagacked in the new version (in most cases just stay the same).

Actual Behavior

The app icon distinguishes and gets replaced by the app logo that shows when an app has no icon set.

Steps to Reproduce

  1. Download & install Neo-Launcher 0.9.2

  2. Set Neo-Launcher as the default start app

  3. Update an installed app 3a) Download & install an old version of e.g. Molly 3b) Update the installed app to a newer version (in case of Molly for example version 5.44.5-1)

Device and OS

  • Device: Google Pixel 6a
  • Android version: 13
  • Launcher version: 0.9.2
  • Rom: GrapheneOS 20220830

MatsG23 avatar Sep 02 '22 18:09 MatsG23

Same as #242, #220, #218 Fixed in commit b116133

saulhdev avatar Sep 03 '22 16:09 saulhdev

Any news on when 0.9.3 will be released, so this fix can be included?

erazemk avatar Sep 04 '22 12:09 erazemk

@erazemk Nope, we're working on migrating settings to Compose and this would take some time. But generally don't ask for ETA.

machiav3lli avatar Sep 05 '22 05:09 machiav3lli

@erazemk Nope, we're working on migrating settings to Compose and this would take some time. But generally don't ask for ETA.

I don't mean to sound impatient, tell you what to do, or seem demanding, but it is a pretty big bug that may cause you to lose users. About 10% of my app icons have been reset to the system default, and it's starting to make it difficult to find apps by looking for their icons.

Personally, I don't plan on switching launchers. However, this version has has been available for almost a month - other users may not be so patient. I'd recommend pushing a patch before too long instead of waiting on other development to be completed.

summersab avatar Sep 06 '22 02:09 summersab

@summersab I think what you're trying to do here is ethically pretty questionable. I wouldn't be bothered by your words personally, but you should reconsider your approach when communicating in FOSS context.

machiav3lli avatar Sep 06 '22 08:09 machiav3lli

The issue is happening with the default icon shape only, so you can change to any other and that will fix the issue.

saulhdev avatar Sep 06 '22 13:09 saulhdev

...I'm so confused. There is a (visually) breaking change. Your team has already pushed a patch. I encouraged you to release an out-of-band update to correct the issue instead of waiting to complete your development cycle. What is unethical about this?

summersab avatar Sep 06 '22 14:09 summersab

I hate to seem pushy, but I have to agree with @summersab. This is a pretty severe bug.

I am willing to live with it, but I intended to use this launcher to replace Nova launcher on my family's devices and now I can't do that, because this issue would be unacceptable to people that aren't as understanding.

cryptikon avatar Sep 21 '22 16:09 cryptikon

As a workaround, you can change the icon shape back and forth to reload the icons.

MatsG23 avatar Sep 21 '22 16:09 MatsG23

As a workaround, you can change the icon shape back and forth to reload the icons.

This does indeed work, but as @cryptikon mentioned, it's a bit of a show-stopper for those who are less technical. I use this launcher on my parents' and grandparents' devices, and there's no way they would remember how to get into the settings to fix the icons. (In fact, one reason I use Neo is because you can lock the desktop, and I DON'T want them to get into the settings to change things).

summersab avatar Sep 21 '22 17:09 summersab

Honestly, as much as I appreciate all the work that is being put into this launcher, I do think this is a major issue which needs to be addressed sooner rather than later. I've been using the launcher for less than a week and I already have had what seems like half of the apps that I use on my home screen revert back to the default icon.

If I hadn't used Omega launcher for so long before the rebrand, at this point, I would switch launchers. Even now, I'm considering switching back to the version I had in the past. I'm not trying to blackmail or throw shade or anything like that; NeoLauncher works fine and I plan on continuing to use it or one of its variants. I'm just saying that new users may be more inclined to use a different launcher if this fix isn't pushed soon. Even if only this patch is pushed and the settings aren't migrated yet and no other changes are made to the software, that'd be great!

Beyond that, thank you so much for the work you put into making and maintaining this launcher! I've been using Omega/Neo Launcher for over a year and have found it to be the best, most customizable launcher out there. I've already recommended it to a few of my friends, and I know at least one of them has switched over and loves it!

2br-2b avatar Sep 22 '22 16:09 2br-2b

I have a bunch of old phones used as smart home and media casting remotes around my house and my extended family's houses. Some kids can't read yet and rely on icons. This issue is the reason I haven't replaced Nova with Neo across the fleet.

surfrock66 avatar Oct 02 '22 22:10 surfrock66

Noticed this as well, honestly very annoying. Pixel 6 Pro, GrapheneOS, Android 13, Neo Launcher F-Droid v0.9.2

seniorm0ment avatar Oct 10 '22 13:10 seniorm0ment

Waiting for out-of-band update to correct the issue

johnexu avatar Oct 20 '22 13:10 johnexu

Waiting for out-of-band update to correct the issue

Yeah, they've made it clear that this isn't going to happen, and asking about it is "unethical," somehow (I'm still trying to figure that one out).

I guess we just have to wait until the next release and keep switching icon styles to fix the issue. It's a bit ridiculous that it's been over two months, though... but I don't want to be "unethical" by mentioning that.

summersab avatar Oct 20 '22 14:10 summersab

@summersab It's so sad that the most beautiful and functional launcher I've ever found treats the user's needs like this.

even more with such a trivial bug.

but at last we will wait.

johnexu avatar Oct 20 '22 14:10 johnexu

Hey, attacking the developers or the project isn't going to change much. The devs who are working on this launcher are probably mostly unpaid, and this is probably a side project for them. Not only that, but they're giving away all of their work for free! Let's leave the personal attacks to the Twitter folks and use Github for constructive feedback.

I do think this is a major bug and a hotfix is of pretty high importance, but let's keep the attacks to a minimum if possible.

2br-2b avatar Oct 20 '22 14:10 2br-2b

I completely agree, @johnexu. I love this launcher. I use it, put it on my parents' phones, and use it for my grandparents' tablets. The "lock desktop" option being somewhat buried in the app settings keep them from mucking up their devices accidentally and calling me for help. I used to use ADW, but unlocking the screen was a simple long-press, tap "unlock," and hit "okay" (something that older people manage to do because they don't necessarily understand what the options mean). Neo solves this problem beautifully. For me, the ability to customize the drawer with categories is something I've wanted in every launcher I've ever had, but none have done it as well as Neo.

The icon issue is a big problem for my family because they'd never be able to figure out to go into settings > customization > icons and toggle the icon shape back and forth. They just have all of their icons reset back to the system default, and they think something is broken. For them, this is NOT a "small" bug.

summersab avatar Oct 20 '22 14:10 summersab

@2br-2b The people here still very sensitive. I love the app but the collection of a feature or bug fix should not be considered unethical u personal attack. I think we're all adults to deal with the circumstances that an open app to the public can bring. save us I'll wait for the next release and that's it!

johnexu avatar Oct 20 '22 15:10 johnexu

Yea, I think it's counterproductive to make demands of people making this software in their free time for free. I am frustrated by the decision to delay, but I respect the devs decision and understand that publishing an update may take time away from their paid job, their families, etc, and that's not ok either.

surfrock66 avatar Oct 20 '22 15:10 surfrock66

I was just about file a bug report about this and found this one. Nice to see it has been already fixed!

l3u avatar Oct 20 '22 16:10 l3u

I completely agree that no one should attack the developers, and I absolutely appreciate the fact that they have developed this launcher in their free time for free. However, I also don't think that developers should attack the users for explaining why a bug is a bigger issue than they may realize. We're trying to help make the product better and grow the user base, after all.

summersab avatar Oct 21 '22 17:10 summersab

The issue has been fixed. we not released a new build yet since we are moving to material3. Hopefully a stable version will come shortly as soon as the migration is complete.

saulhdev avatar Oct 25 '22 22:10 saulhdev

It's finally here…

https://github.com/NeoApplications/Neo-Launcher/releases/tag/0.9.3

machiav3lli avatar Oct 28 '22 09:10 machiav3lli

Everything was solved and the change to material3 became splendid

johnexu avatar Nov 07 '22 06:11 johnexu

I can confirm the bug is fixed. Thanks to everybody involved!

I would like to re-assert that it was never my intention to put pressure on the devs. I know I have no right to demand any kind of change in a free product. I just felt it necessary to convince people that this bug deserved a high priority, because it had an unavoidable impact on virtually every user. I was more concerned about the reputation damage than personal inconvenience.

Thanks again for the excellent work.

cryptikon avatar Nov 10 '22 17:11 cryptikon

I wholeheartedly agree with you, @cryptikon - ESPECIALLY that last sentence:

"I was more concerned about the reputation damage than personal inconvenience."

summersab avatar Nov 12 '22 05:11 summersab

I agree, and I wasn't trying to make it a personal attack. The fact that y'all use GitHub alone shows that y'all are probably at least somewhat familiar with developing software and with how stuff like this works. Again, I agreed and was hoping for a hotfix also.

I've just seen plenty of issue threads turn into many entitled users claiming that an unpaid developer owes them something, which ends up forcing the maintainers to lock the thread and/or become discouraged by the amount of negativity. While I may have been a bit strong in my language, my goal wasn't to attack any of y'all - it was me trying to make sure this discussion remained civil (which, ironically, I'm realizing I may have done in a not-so-civil way). Note that I'm not a contributor or associated with the project - I'm just another user.

Nothing I said here was meant as a personal attack. If anything seemed personal, I'm sorry and that was not the goal. I wish y'all the best and hope all of y'all's future projects go smoothly!

2br-2b avatar Nov 12 '22 06:11 2br-2b