Neo-Feed icon indicating copy to clipboard operation
Neo-Feed copied to clipboard

Neo Feed does not open the feed details when clicking on a card if the Neo Feed app is not launched when using Lawnchair Launcher.

Open sabbaghpierre opened this issue 1 year ago • 4 comments

Describe the bug I'm using Neo Feed as my main feed application using Lawnchair Launcher. If I swipe left from the home screen to the feed and click on a card, nothing happens. If I manually open the Neo Feed app from my drawer, minimize it, go to the feed and click on a card, it will open normally.

Expected behavior Card should open when clicked without the need of having the Neo Feed application open.

Neo Feed Version(please complete the following information):

  • Version 1.7.1 ( Build 1701 )

Smartphone (please complete the following information):

  • Device: Samsung A14
  • OS: Android 14
  • Version Android 14, One UI 6.1

sabbaghpierre avatar Aug 24 '24 14:08 sabbaghpierre

Is this reproducible when using Neo Launcher?

machiav3lli avatar Aug 28 '24 09:08 machiav3lli

When using Neo Launcher the issue is not reproducible, I can open the cards normally.

sabbaghpierre avatar Aug 28 '24 09:08 sabbaghpierre

I am also seeing this issue.

pr0927 avatar Oct 19 '24 16:10 pr0927

I also have the same issue. I am using Neo Feed 1.7.2 hotfix with Lawnchair 15 dev Build #2089

akshxat avatar Mar 19 '25 13:03 akshxat

Same here with latest lawnchair Dev and latest neo release.

SalvatoreNoschese avatar Sep 07 '25 15:09 SalvatoreNoschese

from looking at the custom feed by smartspacer it seems that this requires the display over other apps permission to work correctly can someone check? (LawnChair won't recognize the app when signed with debug signature i can check myself if someone knows how to fix this)

thePrivacyFanatic avatar Oct 21 '25 13:10 thePrivacyFanatic

OK after checking it works to allow lawnchair to recognize it comment out applicationIdSuffix = ".dev" from the app build.gradle so the is would be the same. adding and granting the permission for the 1.8.0 source code works, even though the current code in the repo is broken. current manifest has the permission requested twice so added pr to remove a duplicate declaration

thePrivacyFanatic avatar Oct 21 '25 15:10 thePrivacyFanatic

@thePrivacyFanatic thanks for the PR, merged. So it works currently if you use a release build?

machiav3lli avatar Oct 21 '25 21:10 machiav3lli

@machiav3lli adding it to the old source worked but compiling from latest would crash whenever the launcher tries to load it. this seems to be a different issue, (nullPointerException) but I'm having trouble finding the origin. i could paste logs but it would probably be off topic should i open a new issue?

thePrivacyFanatic avatar Oct 22 '25 05:10 thePrivacyFanatic

@thePrivacyFanatic theoratically it's not off topic, as it is related to having NF function on Lawnchair

machiav3lli avatar Oct 22 '25 06:10 machiav3lli

K here it is. it's kinda weird, it looks like the code it leads to has a check in place to handle null values yet they still get through at least that's what happens on waydroid

FATAL EXCEPTION: main
Process: com.saulhdev.neofeed, PID: 1841
 java.lang.NullPointerException: Parameter specified as non-null is null: method
com.saulhdev.feeder.manager.service.ConfigurationOverlayController.createController, parameter configuration
at com.saulhdev.feeder.manager.service.ConfigurationOverlayController.createController(Unknown Source:2)
at com.google.android.libraries.gsa.d.a.MinusOneOverlayCallback.createController(MinusOneOverlayCallback.java:21)
at com.google.android.libraries.gsa.d.a.OverlayControllerCallback.handleInit(OverlayControllerCallback.java:61)
at com.google.android.libraries.gsa.d.a.OverlayControllerCallback.handleMessage(OverlayControllerCallback.java:36)
at com.google.android.libraries.gsa.d.a.MinusOneOverlayCallback.handleMessage(MinusOneOverlayCallback.java:36)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7924)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:937)

thePrivacyFanatic avatar Oct 22 '25 12:10 thePrivacyFanatic

@thePrivacyFanatic This should be fixed now

machiav3lli avatar Oct 22 '25 22:10 machiav3lli

now it works and it only has 5 build warning complaining about a function not being annotated instead of the hundreds before. that's nice i could switch off of the annoying smartspacer capy reader setup to this now that it works again also sorry for late answer, different timezones and such

thePrivacyFanatic avatar Oct 23 '25 13:10 thePrivacyFanatic

A new release would come in the next days, with some other fixes and performance optimizations… so if you'd like to avoid always building by yourself, maybe you can wait a bit

machiav3lli avatar Oct 23 '25 14:10 machiav3lli

But wait Did we add a part actually asking the user for the permission? I could try to add it in a couple of hours when I'll be near my PC again

thePrivacyFanatic avatar Oct 24 '25 04:10 thePrivacyFanatic

@machiav3lli added pr took me way to long to realise how android studio pushes to GitHub but now its done also i noticed an issue in waydroid where it can still work with the permission revoked but their bug report template dosent fit, if anyone has advice on how to report this it would be nice

thePrivacyFanatic avatar Oct 24 '25 18:10 thePrivacyFanatic

@machiav3lli just wanna know if this is getting merged and if a new release is coming out since I've been looking at this issue for quite some time (Actually before I've opened my account)

thePrivacyFanatic avatar Oct 27 '25 07:10 thePrivacyFanatic

@thePrivacyFanatic I don't get the impatient (as seen in the deleted domments). Furthermore, please note that the permission isn't needed to work with Neo Launcher, so Lawnchair should be able to fix the issue on their side without the permission (although never tested NF with Lawnchair)

machiav3lli avatar Nov 02 '25 12:11 machiav3lli

@thePrivacyFanatic I don't get the impatient (as seen in the deleted domments).

Sorry if it was annoying I was just waiting to get this fixed and to be able to use the app again (since the smartspacer + capy reader setup I have rn sucks) or to know if the PR had a problem (so I can fix it) Anyways thanks for the merge waiting to switch back to this once the new build releases

thePrivacyFanatic avatar Nov 02 '25 13:11 thePrivacyFanatic

Should be now fixed with the new release

machiav3lli avatar Nov 09 '25 17:11 machiav3lli