Neo-Backup icon indicating copy to clipboard operation
Neo-Backup copied to clipboard

[Bug] Empty Applist and Blocklist crash for v8.3.7

Open shuvashish76 opened this issue 1 year ago • 13 comments

Description The App list is empty & clicking on Blocklist crashes the app.

Steps To Reproduce

  1. Allow all initial asked permissions
  2. Homepage app list is completely empty without any sort or filter.

Expected behavior Show App list.

Screenshots

Details

Screenshot_2024-08-01_04-31-41 Screenshot_2024-08-01_04-31-48

Additional info Clicking on the Blocklist crashes the app

Logs

FATAL EXCEPTION: main
Process: com.machiav3lli.backup, PID: 13216
java.lang.NoClassDefFoundError: com.machiav3lli.backup.actions.BaseAppAction
	at com.machiav3lli.backup.utils.Dirty.PackagesListDialogUI(Unknown Source:101)
	at com.machiav3lli.backup.utils.Dirty.GlobalBlockListDialogUI(Unknown Source:35)
	at com.machiav3lli.backup.pages.MainPageKt$MainPage$4$4.invoke(Unknown Source:1928)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at com.machiav3lli.backup.pages.WelcomePageKt$WelcomePage$1.invoke(Unknown Source:844)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.ui.window.AndroidDialog_androidKt$Dialog$dialog$1$1$1.invoke(Unknown Source:83)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.animation.Scale$$ExternalSyntheticOutline0.m(SourceFile:66)
	at androidx.biometric.ErrorUtils.access$DialogLayout(Unknown Source:167)
	at androidx.compose.ui.window.AndroidDialog_androidKt$Dialog$dialog$1$1$1.invoke(Unknown Source:135)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.ui.window.DialogLayout.Content(Unknown Source:19)
	at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(Unknown Source:162)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.runtime.Updater.CompositionLocalProvider(SourceFile:29)
	at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(Unknown Source:282)
	at androidx.compose.material3.MenuKt$DropdownMenuContent$2.invoke(Unknown Source:106)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.runtime.Updater.CompositionLocalProvider(SourceFile:29)
	at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(Unknown Source:458)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Unknown Source:37)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.runtime.Updater.CompositionLocalProvider(SourceFile:74)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Unknown Source:184)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:8)
	at androidx.compose.runtime.Updater.invokeComposable(Unknown Source:14)
	at androidx.compose.runtime.ComposerImpl.doCompose(Unknown Source:121)
	at androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Unknown Source:10)
	at androidx.compose.runtime.CompositionImpl.composeContent(Unknown Source:34)
	at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Unknown Source:43)
	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Unknown Source:4)
	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Unknown Source:4)
	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Unknown Source:4)
	at androidx.compose.runtime.CompositionImpl.composeInitial(Unknown Source:8)
	at androidx.compose.runtime.CompositionImpl.setContent(Unknown Source:2)
	at androidx.compose.ui.ZIndexNode$measure$1.invoke(Unknown Source:562)
	at androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(Unknown Source:6)
	at androidx.compose.ui.platform.WrappedComposition.setContent(Unknown Source:8)
	at androidx.compose.ui.platform.WrappedComposition.onStateChanged(Unknown Source:18)
	at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(Unknown Source:22)
	at androidx.lifecycle.LifecycleRegistry.addObserver(Unknown Source:216)
	at androidx.compose.ui.ZIndexNode$measure$1.invoke(Unknown Source:531)
	at androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(Unknown Source:97)
	at android.view.View.dispatchAttachedToWindow(View.java:18347)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3397)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3404)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3404)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3404)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3404)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1764)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1463)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7190)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
	at android.view.Choreographer.doCallbacks(Choreographer.java:761)
	at android.view.Choreographer.doFrame(Choreographer.java:696)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6718)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Caused by: java.lang.ExceptionInInitializerError
	at com.machiav3lli.backup.viewmodels.MainViewModel$packageList$1.invokeSuspend(Unknown Source:83)
	at com.machiav3lli.backup.viewmodels.MainViewModel$packageList$1.invoke(Unknown Source:19)
	at kotlinx.coroutines.flow.FlowKt__ZipKt$combine$1$1.invokeSuspend(Unknown Source:205)
	at kotlinx.coroutines.flow.FlowKt__ZipKt$combine$1$1.invoke(Unknown Source:74)
	at kotlinx.coroutines.flow.internal.CombineKt$combineInternal$2.invokeSuspend(Unknown Source:253)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:114)
	at androidx.work.Worker$2.run(Unknown Source:10)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Unknown Source:2)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(Unknown Source:95)
Caused by: java.io.FileNotFoundException: /data/user/0/com.machiav3lli.backup/files/definition/ignored_packages.regex (No such file or directory)
	at java.io.FileInputStream.open0(Native Method)
	at java.io.FileInputStream.open(FileInputStream.java:231)
	at java.io.FileInputStream.<init>(FileInputStream.java:165)
	at kotlin.io.FilesKt.readText$default(Unknown Source:11)
	at com.ma
```chiav3lli.backup.actions.BaseAppAction.<clinit>(Unknown Source:12)
	... 10 more

System Information(please complete the following information):

  • Device: Lenovo Tab4 8 plus
  • Android Version: 9
  • ROM: LineageOS
  • App's Version: 2.7.3

Additional Notes

Originally reported on F-Droid forum : https://forum.f-droid.org/t/latest-version-of-neo-backup-8-3-7-completely-broken-downgraded-to-8-3-6/26822

shuvashish76 avatar Jul 31 '24 23:07 shuvashish76

I can confirm this behavior on my OnePlus 5T running LineageOS 21 (Android 14) after update from 8.3.6 to 8.3.7 via FDroid. Logcat attached showing several exceptions after opening NeoBackup and waiting for the initial automatic "refresh". Let me know if I can provide any other info that would help. Thanks for your work on a great app!

logcat_neobackup_8-3-7_07-31-2024_22-25-40.txt

Cbhack13 avatar Aug 01 '24 02:08 Cbhack13

assets/files folder is missing from the F-Droid build for some reason

/LE: disabled on F-Droid, will disappear next-next index update: https://gitlab.com/fdroid/fdroiddata/-/commit/625e0044da7216761866a93cf5b9c6e27fe6c080

licaon-kter avatar Aug 01 '24 09:08 licaon-kter

Can confirm, izzy droid version is working but fdroid version doesnt have app list and crashes alot

fluoriteByte avatar Aug 01 '24 09:08 fluoriteByte

Same issue on F-droid version. As well, Neo Store would not install 8.3.7 (I will post this in Neo Store).

Prodigalmanboy avatar Aug 01 '24 10:08 Prodigalmanboy

I can confirm same on OnePlus 6 running android 11. F-droid distribution.

macerg avatar Aug 02 '24 06:08 macerg

Can confirm for Pixel 7 with Android 14 vanilla.

pseisam avatar Aug 02 '24 07:08 pseisam

You can just :+1: the issue instead of spamming everyone with "mee to":)

licaon-kter avatar Aug 02 '24 08:08 licaon-kter

And you can go to hell.Regards,Richard MaceOn 2 Aug 2024 09:08, Licaon_Kter @.***> wrote: You can just 👍 the issue instead of spamming everyone with "mee to":)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

macerg avatar Aug 02 '24 08:08 macerg

You can just 👍 the issue instead of spamming everyone with "mee to":)

Yes, I did that too, but I also wanted to confirm that it affects "normal" devices also like a Pixel with vanilla OS and not only custom OS like Lineage or the OnePlus OS.

pseisam avatar Aug 02 '24 11:08 pseisam

Exactly, and that's what I did in pointing out the problem on my OnePlus 6 Android 11 which no-one else had done. Regards,Richard MaceOn 2 Aug 2024 12:02, pseisam @.***> wrote:

You can just 👍 the issue instead of spamming everyone with "mee to":)

Yes, I did that too, but I also wanted to confirm that it affects "normal" devices also like a Pixel with vanilla OS and not only custom OS like Lineage or the OnePlus OS.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

macerg avatar Aug 02 '24 11:08 macerg

Caused by: java.io.FileNotFoundException: /data/user/0/com.machiav3lli.backup/files/definition/ignored_packages.regex (No such file or directory)

This seems the key issue. The file ignored_packages.regex is added and used in https://github.com/NeoApplications/Neo-Backup/commit/1a7fc014f9410e0f83a6b04c4640198629bc6240. However, the file was lost during a refactor in https://github.com/NeoApplications/Neo-Backup/commit/ff71483580cfa70723e0fe9aa497a61184c350c5. That file and some other relevant ones are added back in https://github.com/NeoApplications/Neo-Backup/commit/6a1192c6be20395c3705f790e1534e27760adc67, which is after version 8.3.7.

yan12125 avatar Aug 02 '24 15:08 yan12125

Auf meinem FP5 mit Android 13 ist es dasselbe. Keinerlei Funktion mehr seit letztem Update. Dafür jede Menge Abstürze. Kaputt gespielt.

magister81 avatar Aug 02 '24 17:08 magister81

If it can help I do have the same problem: Pixel 3a sargo, lineage os 21 with android 14

Martinligabue avatar Aug 02 '24 19:08 Martinligabue

should be fixed now with the 8.3.8 release.

@licaon-kter now that there's this chance, could you also please clean up the icon's cache on F-Droid's side as it is still showing the icon from OABX days (maybe for different locales?).

Screenshot_20240804-144600

machiav3lli avatar Aug 04 '24 12:08 machiav3lli

What icons cache?

Icons are pulled from https://github.com/NeoApplications/Neo-Backup - fastlane - locale - images/icon.png

Are those all correct here in the repo?

licaon-kter avatar Aug 04 '24 12:08 licaon-kter

@licaon-kter yup all are correctly, current here. But F-Droid (the repo) still seems to provide an older icon as showing in the screenshot (this icon was deleted a bit over 2 years ago).

machiav3lli avatar Aug 04 '24 13:08 machiav3lli

Screenshots are a different matter, if you added screenshot instead of replacing they might have sticked.

List them for deletion in https://gitlab.com/fdroid/admin/-/issues/377

licaon-kter avatar Aug 04 '24 13:08 licaon-kter

@licaon-kter nope, the screenshot only meant the picture included in my previous comment. The issue is with the app icon only, having this not existing anymore icon as the app icon.

machiav3lli avatar Aug 04 '24 13:08 machiav3lli

Ah, ok.

Now, care to explain where was that screenshot capture from? Which app?

licaon-kter avatar Aug 04 '24 15:08 licaon-kter

The screenshot was from Neo Store enabling only the official f-droid (as IzzyOnDroid have it already fixed). Also as mentioned, I think it could be a caching+localization issue, where the old icon that was once included in the different locales is kept instead of being replaced with the new EN single one.

machiav3lli avatar Aug 04 '24 16:08 machiav3lli

Do reproduce this issue with F-Droid Client, not sure where other clients pull the metadata from exactly.

Or just link to the exact file in f-droid.org/repo/.....

licaon-kter avatar Aug 04 '24 16:08 licaon-kter

Directly reproducible on the official client. Also checked my theory that it's a combination of locale and older kept icon, so for you to reproduce just have non-EN like DE as locale. Which means that the older version which was once included with a certain release in each of the locals is kept, ignoring the current EN one and falling back to it as default, rather using the "cached" icon.

Screenshot_20240804-200703

machiav3lli avatar Aug 04 '24 18:08 machiav3lli

Confirmed, will try to list them and add them to the next cleanup

licaon-kter avatar Aug 04 '24 18:08 licaon-kter

@licaon-kter cool! Thanks!

machiav3lli avatar Aug 04 '24 18:08 machiav3lli

@licaon-kter not issue-related, but similar to the icon thingy, Neo Store package in the official f-droid repo index seems to still have old, long deleted screenshots.

machiav3lli avatar Sep 19 '24 19:09 machiav3lli

Do the thing, post in the admin issue

licaon-kter avatar Sep 19 '24 20:09 licaon-kter