Loki icon indicating copy to clipboard operation
Loki copied to clipboard

move from py2 to 3

Open ruppde opened this issue 3 years ago • 3 comments

works perfectly for yara and filename iocs, not a byte difference in the logs on 1600 hits. but I didn't have test cases for wmi and process scanning.

it's not backwards compatible to python2 because it was awkward at some places with the conversions between old unicode, bytes, str, ... and py2 is end of life anyway.

ruppde avatar Jan 16 '21 23:01 ruppde

Thanks

  1. the tests still run with Python 2
  2. I have to setup a build system that builds this version with PyInstaller and Python3 first - otherwise I cannot publish releases

Neo23x0 avatar Jan 17 '21 10:01 Neo23x0

is python 2 really needed? I remember that there were some parts of the code which returned wrong data types + https://github.com/Neo23x0/Loki/pull/158/commits/eee529f8298ead82fdd41c1fe4c4e9ae90a5e725 would need to adopted.

ruppde avatar Jan 17 '21 19:01 ruppde

Please resync to resolve conflicts.

cclauss avatar Jul 20 '21 06:07 cclauss