NEMO icon indicating copy to clipboard operation
NEMO copied to clipboard

[Feature request] Extend the NPC ID on older client

Open zackdreaver opened this issue 9 years ago • 14 comments

Tested with 2012-04-10aRagexeRE All NPCs with ID starting 10001 can't be read by client, it will replace with "poring" sprite

Is it possible to extend it, sir NEO?

Thank you

zackdreaver avatar Jan 03 '16 06:01 zackdreaver

NPC or Mob?

Neo-Mind avatar Jan 04 '16 09:01 Neo-Mind

NPCs are confirmed, haven't test with mob. Cus the new mobs (id +10k) are mostly event mobs and new mobs from ep 16+

zackdreaver avatar Jan 04 '16 09:01 zackdreaver

what i mean is if you want the ids to be enabled for using as NPCs that is possible (its simply a matter of adding one extra loop for reading the extra ids from lua file). But if you want them to be used for Mobs then it won't be easy and I am not going to pursue that atm.

Neo-Mind avatar Jan 04 '16 10:01 Neo-Mind

I want just extended NPC id right now.

zackdreaver avatar Jan 04 '16 10:01 zackdreaver

@MStr3am include also mob, not only npc, or maybe do a 2 patches, so that the admin can choose 1 of them.

Jedzkie avatar Jan 04 '16 23:01 Jedzkie

@Jedzkie I guess you didn't notice this part. "But if you want them to be used for Mobs then it won't be easy and I am not going to pursue that atm"

Neo-Mind avatar Jan 05 '16 14:01 Neo-Mind

@mstream ye, but the ids of npc and mob in client are different right?

Jedzkie avatar Jan 05 '16 22:01 Jedzkie

Point is client reads the suffix for the set of ids and put the appropriate prefix when it is used as npc or mob. You can try using it as a mob but you will get the NPC cursor and won't be able to attack it.

Fixing the 2nd part is what i was referring to .

Anyways I will put up a patch to create an extra loop for the 10K+ id from lua files.

Neo-Mind avatar Jan 06 '16 08:01 Neo-Mind

@MStr3am may you include 2010 clients also thanks

Jedzkie avatar Jan 08 '16 01:01 Jedzkie

I have added a patch 'Increase NPC Ids' try it out.

Neo-Mind avatar Jan 09 '16 07:01 Neo-Mind

Not work with 2012-04-10aRagexeRE Min ID: 1000 Max ID: 20000 test npc: 4_F_SHALOSH (10041)

screenlocal000

and crashed with 2010-04-20aRagexeRE

zackdreaver avatar Jan 09 '16 09:01 zackdreaver

hmm looks like it is more complicated than i thought. The extra loop is not enough. Along with what i mentioned earlier about the Mob IDs, the sprite is also getting picked up from ¸ó½ºÅÍ folder instead of NPC folder.

At the moment I am putting this on hold. Even If I complete this it's probably not gonna be a public patch.

Neo-Mind avatar Jan 09 '16 15:01 Neo-Mind

Noted ^ Disregard my herc.ws forum post, please!

jTynne avatar Jan 10 '16 11:01 jTynne

Hi MStr3am, Have you made any progress on this patch? Willing to compensate/commission the patch's creation if you've either finished it or are willing to embark on working on this.

jTynne avatar Aug 01 '17 08:08 jTynne