meteor-bootstrap icon indicating copy to clipboard operation
meteor-bootstrap copied to clipboard

path generation code ignores the ROOT_URL env var

Open csillag opened this issue 8 years ago • 4 comments

When running our Meteor 1.3 project, we have the ROOT_URL env var set to /whatever/, and so all the resources are served under that path.

However, in the autogererated custom.bootstrap.less, I see this line:

@icon-font-path: "/packages/nemo64_bootstrap-data/bootstrap/fonts/";

This path doesn't contain the ROOT_URL, and consequently, fonts don't work.

In the meteor code, the path should be generated by the Meteor.absoluteUrl() function, which automatically honors the env var.

csillag avatar May 17 '16 09:05 csillag

See Readme — this package works only with 1.1 and older.

simison avatar May 17 '16 10:05 simison

Well, for me, it works OK with Meteor 1.3... and this PR fixes the problem:

https://github.com/Nemo64/meteor-bootstrap/pull/70

csillag avatar May 17 '16 10:05 csillag

Oh, that's interesting! Perhaps it simply started working again. With 1.2 it didn't work. :-)

@Nemo64 @emgee3 do you know about this?

Nevertheless https://github.com/huttonr/bootstrap3 is better up to date.

simison avatar May 17 '16 10:05 simison

Honestly haven't looked because I've been using huttonr's package...

emgee3 avatar May 17 '16 20:05 emgee3