Nemo157

I mean the web browser parsing the response, since that's the only thing I could see this really impacting. (If we do want to reduce the page size, rather than...

gzipped transfer sizes: | page | before | with this PR | diff | [with `minify-html`](https://github.com/rust-lang/docs.rs/compare/master...Nemo157:docs.rs:minify-middleware) | diff | |----|----|----|---|---|---| | https://docs.rs/sysinfo/0.29.7/sysinfo/index.html | 13.08kB| 12.47kB | -4.7% | 12.03kB |...

I downloaded the `/about` page from this PR and my change, then ran them both through `tidy --indent yes --wrap 0 --sort-attributes alpha` to normalize them, results: https://gist.github.com/Nemo157/fccc65481dc61f3409f8865bc4f8d452 Looking at...

> and it's generating invalid HTML What part is invalid? In my tests I was using `minify_html::Cfg::spec_compliant` which is meant to be 100% valid. (There are a few open bugs,...

@alex there's also an [unreleased blog post about the compat shims](https://github.com/rust-lang-nursery/futures-rs/blob/ac16bedf0edb9e30e74465dd9202e182b702bf18/_posts/2018-01-01-compatibility-layer.md). The blog post is based on a slightly older version where the [`TryFutureExt::compat`](https://rust-lang-nursery.github.io/futures-api-docs/0.3.0-alpha.9/futures/future/trait.TryFutureExt.html#method.compat) method took a spawner, that's now...

More of an issue is that just looking at the function signatures I'm 99% sure it is unsound. If I were to call `unit_wasm::rusty::uwr_get_http_path(0x12345 as *const unit_wasm::rusty::luw_ctx_t)` does this not...

The key is that you should either: * expose the fact that the API is unsafe by declaring it `unsafe fn` (and then describe in the documentation what preconditions are...

> Where is the undefined behaviour? Or do you _really_ mean UB (where the compiler is free to do what it likes) or something else? In my example: ```rust unit_wasm::rusty::uwr_get_http_path(0x12345...

Rust's safety rules do not require common sense of users, they are designed to _guarantee_ memory safety in the face of bugs in safe code.

`target.runner` is handled when using `-Zdoctest-xcompile`, even when not cross-compiling (https://github.com/rust-lang/cargo/issues/7040)