async-compression icon indicating copy to clipboard operation
async-compression copied to clipboard

fix: Encoder state machine tolerates being wrapped by an `AsyncWrite`

Open aatifsyed opened this issue 1 year ago • 4 comments

Simplified the Encoder state machine. It should now handle poll_flush calls after poll_shutdown calls.

Closes #308 See also #246

aatifsyed avatar Oct 31 '24 16:10 aatifsyed

Thanks!

You are right, poll_shutdown should indeed call self.poll_flush before calling inner.poll_shutdown

NobodyXu avatar Nov 01 '24 07:11 NobodyXu

Thanks!

You are right, poll_shutdown should indeed call self.poll_flush before calling inner.poll_shutdown

NobodyXu avatar Nov 01 '24 07:11 NobodyXu

What's the level of enthusiasm on this PR?

aatifsyed avatar Mar 26 '25 18:03 aatifsyed

What's the level of enthusiasm on this PR?

I can continue review once the feedback has been addressed

NobodyXu avatar Mar 27 '25 07:03 NobodyXu