Nelson Vides comments

Results 74 comments of


                                            Nelson Vides

Exit proc_lib gracefully on proxy header mismatch

I've just tried to write a test for it. Will deploy this in my env in the next few days and will let you know, in the meantime please let...

Exit proc_lib gracefully on proxy header mismatch

@essen tested in my environments, I do get `{error, closed}` and logs aren't dirty with crashes.

Exit proc_lib gracefully on proxy header mismatch

> Please don't add a new test group and instead make the test against all http/https/h2/h2c instead so we know it's working for both TCP and TLS and all protocols....

Exit proc_lib gracefully on proxy header mismatch

Just pushed the test, it generally fails the https group with a timeout when waiting for the 'DOWN' message.

Exit proc_lib gracefully on proxy header mismatch

Right, the Pid that `ct_helper:get_remote_pid_tcp/1` is not the same than the socket is listening to, so it doesn't receive the `DOWN` message. This happens only for the `https` and `h2`...

Exit proc_lib gracefully on proxy header mismatch

> There's a separate function for TLS. Just saw that, but that won't work, because it's doing ssl:sockname, and this socket is not yet a ssl socket, it's a barebones...

Exit proc_lib gracefully on proxy header mismatch

@essen now, I've pushed a new version of the test that does a bit of a hack, hopefully elegant, to correctly find the process we want to track the dead...

Exit proc_lib gracefully on proxy header mismatch

@essen did you have a chance to review the latest changes? :)

Exit proc_lib gracefully on proxy header mismatch

> No but the tab is still open for whenever this can happen. Hi there, it's been a while, how's progress on this one? :)

Exit proc_lib gracefully on proxy header mismatch

@essen heads up on this, any updates, plans?