amazon-dash icon indicating copy to clipboard operation
amazon-dash copied to clipboard

Provide custom success/failure messages

Open chrissv opened this issue 5 years ago • 2 comments

What is the purpose of your issue?

  • [ ] Bug report (encountered problems with amazon-dash)
  • [x] Feature request (request for a new functionality)
  • [ ] Question
  • [ ] Other

Description

Currently the text for the confirmation is either the output of the command, or a generic The {} device has been executed successfully. This enhancement is to provide custom success and failure text in the yml file for the confirmations, for example:

devices:
  78:e1:03:b5:44:aa:
    name: test_button
    cmd: some_command
    ssh: localhost
    confirmation: send-tg
    msg_success: {name} light is turned on
    msg_failure: Something bad happened with {name} - check log

(msg_success and msg_failure are the new parameters, as a suggestion)

In addition to the new messages, it would be nice to have some kind of primitive substitutions within the messages for things like the name, and maybe others that would make sense (such as date and time, and output from the cmd).

chrissv avatar Feb 05 '20 05:02 chrissv

Added to milestone v1.5.0!

Nekmo avatar Mar 01 '20 00:03 Nekmo

Do you plan on adding any variable substitutions, like {name} and/or {date}? If so, which ones make sense?

chrissv avatar Mar 01 '20 05:03 chrissv