Maxime Veber
Maxime Veber
What is the usecase ? You set the directory in the adapter by yourself.
Many points may be improved here: - Using `XXException` is already self-describing (and is a PHP convention) - Exceptions should inherit from `LogicException` and `RuntimeException` - Doc about their existence...
@ob-stripe I meant add a part in the README that says what exception will be throw when. (because this is complicated to understand ATM) :+1: changes you planned sound nice
We need a benchmark for many browsers and different versions of nodejs for this one :/ .
I know it's late, but it's fixed :) .
@schteppe do you encourage a fork?
This need a test. But it's a good point.
This may be close I guess.
@rh389 please tag it as help wanted if you accept my solution. cc @thewilkybarkid
Here is a link to: https://discord.gg/NKYgCBP