Jay Herron
Jay Herron
@xtremekforever Good reminder - thanks! I've rebased this branch, and I think it's ready to go now! Unfortunately I couldn't get rid of all the Swift 6 warnings since we're...
Thanks @3a4oT Just wondering - Are there any particular needs you had for upgrading this, or were you just cleaning it up?
@paulofaria Do you have any thoughts on this? I know you've been hesitant to update swift-tools versions in the past, but NIO is [at 5.8 compatibility](https://github.com/apple/swift-nio/blob/main/Package.swift#L1)
Hey @3a4oT, I think this is good to go if you just make the following changes: 1. Remove dependency changes in `Package.swift` 2. Run the formatter: `docker run --rm -v...
I'm okay merging this and dropping 5.8 after NIO does. > By the way, I think we should be explicit about our versioning support. The main question is do we...
> I think at this point we'll probably stick with the built in stuff in the responder otherwise we risk breaking apps that rely on it and we don't want...
It looks like you were doing the right thing using `GraphQLJSONEncoder`. Do you happen to know what Decoder `client.runGraphQLQuery` is using under the hood to convert to a `GraphQLResult`? For...
Oh okay, that makes sense. For background, `GraphQLResult.data` uses the `Map` structure, which itself uses an `OrderedDictionary` of fields. This is important in order to deliver the correct ordering of...
I believe if you change this line from `v3` to `v4`, that will resolve the 'Test on Linux' check: https://github.com/GraphQLSwift/DataLoader/blob/52b1f3d96adf2ddce348f698f46ec8e7827493dc/.github/workflows/build.yml#L54
I'm inclined to agree with @ZirgVoice. Batching works by slightly pausing execution to allow more `load` calls to get into the DataLoader's queue. This works because `queue.append` happens before any...