Sia icon indicating copy to clipboard operation
Sia copied to clipboard

Better Updating of Renter Persistence

Open eddiewang opened this issue 7 years ago • 3 comments

Want to put this idea down here while it's fresh. I recently migrated to a new Macbook Pro (yay), and copied my renter folder over. Since I was playing around with setting up siad again, I vim'd into the renter folder to read some of the logs.

There are some easy fixes that can be implemented to the Renter Persistence file. image

  1. Renter tracking files that have been deleted Maybe there is an underlying reason to do this, but the renter persistence file seems to continue to track files that have been long deleted either through Sia-UI or siac. We should clean these files up as they are no longer necessary.

  2. Update repair path as file downloads The repair path seems to be set upon first upload, and it is no longer changed. I'm not sure how the online repair works, but I am assuming the file is downloaded to cache, repaired by uploading to new contracts, and then deleted from cache. We should be updating the location of the file everytime the file is downloaded.

In my case, I've redownloaded all the files I've stored on Sia into a new folder on my computer, and deleted the old files. The renter log now shows that it's having problems repairing the files through the renter: image

I'm not sure if these glitches are happening because of the version updates, but we should have a cleanup next update that properly syncs the persistence file so it can better handle file repairs.

eddiewang avatar Aug 24 '17 11:08 eddiewang

Seems like a bug to me.

Recommendation to devs: tag as 'bug'

tbenz9 avatar Oct 06 '17 20:10 tbenz9

Agreed on point 1. As for point 2, I think we'd want something akin to what BitTorrent clients do: let the user specify the new location of the file (or a folder of files).

lukechampine avatar Nov 13 '17 23:11 lukechampine

Point 1 will be addressed with the new file format #2204

MSevey avatar Jun 04 '18 20:06 MSevey