Sia-UI icon indicating copy to clipboard operation
Sia-UI copied to clipboard

Add autoprefixer.

Open moimael opened this issue 8 years ago • 2 comments

Remove vendor prefixes and use a browserlist to state which target we support. Soon babel-preset-env will support the browserlist file too so we can simplify the configuration further.

moimael avatar May 16 '17 17:05 moimael

Is there reason to expect that we'll need to support a non-webkit target in the future? Just unsure if this makes things more clear or less clear if you're a new dev diving into the codebase. Typically we try to keep our dependencies as minimal as possible.

lukechampine avatar May 16 '17 17:05 lukechampine

It's not really for non webkit support in this case, more for not yet standard props. The problem with prefixed css properties is that they are forgotten and will never get changed, while the standard one might get some improvement from browser engine dev (see flexbox for example). With autoprefixer you only write standard css and it will add prefixes when needed and remove them when they are fully supported.

Given the current size of the project, the benefit is not obvious, but when/if it grows, I think this is really worth it.

Also the dependency is only for dev, so it wont make the program larger and is quite small with minimal configuration.

moimael avatar May 16 '17 17:05 moimael