Sia-GPU-Miner icon indicating copy to clipboard operation
Sia-GPU-Miner copied to clipboard

fixed incorrect hashrate on mac os and fixed some memleaks

Open gjwang opened this issue 7 years ago • 3 comments

gjwang avatar Nov 09 '16 18:11 gjwang

Thanks for the pull request!

We'll get to reviewing this as soon as we can.

DavidVorick avatar Nov 10 '16 15:11 DavidVorick

Looks good overall. I would prefer to see the device info printed in a nicer format. Aside from that, just make sure you follow our current style, specifically:

  • Tabs for indentation
  • Open brace on the same line, separated by a space (e.g. foo() {)

lukechampine avatar Nov 12 '16 20:11 lukechampine

Excellent. I think this is good to merge, but I would like to confirm that it behaves as intended on Windows and Linux as well. @DavidVorick, can we push this out to some miners and get their feedback?

lukechampine avatar Nov 13 '16 18:11 lukechampine