Nebula icon indicating copy to clipboard operation
Nebula copied to clipboard

Kills /datum/dna.

Open MistakeNot4892 opened this issue 10 months ago • 2 comments

Description of changes

Biting the bullet on this one so there's some kind of forward movement.

  • Deletes /datum/dna and all associated hooks.
  • Replaces it in organ and mob contexts with /datum/mob_snapshot which is generated on demand
  • Converts genetic conditions (superpowers and disabilities) to /decl/genetic_condition.

Why and what will this PR improve

With current DNA, the tail is wagging the dog. The overcomplexity makes it prohibitive to work with considering the actual use cases. The replacement is generated from the mob when needed rather than constantly maintained, is MUCH simpler, and doesn't get as tangled up in the ideas implied by naming it 'DNA' as the previous implementation.

TODO

  • [X] Test and see that basic setup and joining actually works.
  • [X] Reimpement mutation toggles (decl system?)
  • [x] Readd genetics spells
  • [x] Readd anomaly stuff.
  • [x] Fix up markings tracking and have it track bodytype as well.
  • [x] Readd DNA scrambling.
  • [x] Test species and bodytype setting.
  • [x] Test bioprinter.
  • [ ] Test mutagen.
  • [ ] Test DNA switching artifact.
  • [ ] Test genetics overlay.

Authorship

Myself.

Changelog

Nothing player-facing.

MistakeNot4892 avatar Apr 12 '24 03:04 MistakeNot4892

image

I may have broken something.

MistakeNot4892 avatar May 22 '24 08:05 MistakeNot4892

In the end I reimplemented the scrambling effects a little differently. Unique enzymes are only used for forensics, so scrambling those is whatever. The DNA artifact scrambles hair and colouration as well, Other scramble effects just add random disabilities or superpowers.

MistakeNot4892 avatar May 22 '24 09:05 MistakeNot4892

Ready to go.

MistakeNot4892 avatar Jun 08 '24 12:06 MistakeNot4892