Nebula icon indicating copy to clipboard operation
Nebula copied to clipboard

[MDB IGNORE] [IDB IGNORE] Natural flooring now uses /decl/flooring

Open MistakeNot4892 opened this issue 10 months ago • 3 comments

Description of changes

  • Converts all natural turfs to use /decl/flooring.
  • Moves as much as possible from /turf/floor/natural to /turf/floor and /decl/flooring.

Why and what will this PR improve

Unifies all the code in one spot and makes it much easier to avoid ChangeTurf(). Prep work for layered flooring in the future.

TODO

  • [X] Readd digging
  • [x] Test digging
  • [X] Test removing and replacing tiles
  • [x] Readd everything else clobbered by merge resolution.
  • [x] Finish converting natural turfs (lava)
  • [x] Get edges working again.
  • [ ] Get edge layering working again.
  • [ ] Test all natural flooring.
  • [x] Test digging products and trenches.
  • [ ] Test tilling natural floors.
  • [x] Add map migration.

Authorship

Myself.

Changelog

Hopefully nothing player-facing.

MistakeNot4892 avatar Apr 11 '24 01:04 MistakeNot4892

did not realize this wasnt review-ready, oops

out-of-phaze avatar Apr 11 '24 06:04 out-of-phaze

image

MistakeNot4892 avatar Aug 15 '24 01:08 MistakeNot4892

PR is mostly fine other than issues with edge layering. Any input on this would be good, I find opening the PR exhausting at the moment.

MistakeNot4892 avatar Aug 20 '24 04:08 MistakeNot4892

image Trench edges are overlaying the turf they are meant to be below.

MistakeNot4892 avatar Sep 21 '24 12:09 MistakeNot4892

  • Trenches seem to be working.
  • Base turf on brick/log walls is set to dirt.
  • Base turf for Shadyhills wooden turfs is set to dirt.

MistakeNot4892 avatar Sep 21 '24 12:09 MistakeNot4892