Nebula icon indicating copy to clipboard operation
Nebula copied to clipboard

Space turfs do not update their ambient light when a dynamically lit turf is created beside them.

Open MistakeNot4892 opened this issue 2 years ago • 2 comments

Description of issue

See title.

Difference between expected and actual behavior

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf, as otherwise you would have thousands of space turfs pointlessly creating corners etc. However as it stands, they should be updated when a dynamically lit turf is created beside them.

Steps to reproduce

  • Enable starlight.
  • Go to space.
  • Spawn a turf.
  • Put a non-fullbright light source on the turf or nearby.
  • Observe that the edges are dark as though bordering a fulldark turf.

Specific information for locating

I believe this was previously handled in simulated turf init, but not sure.

Length of time in which bug has been known to occur

Presumably since ambient lights were added..

Client version, Server revision & Game ID

Current dev.

Issue bingo

  • [X] Issue could be reproduced at least once
  • [ ] Issue could be reproduced by different players
  • [X] Issue could be reproduced in multiple rounds
  • [X] Issue happened in a recent (less than 7 days ago) round
  • [X] Couldn't find an existing issue about this

MistakeNot4892 avatar Oct 19 '22 05:10 MistakeNot4892

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf

? this doesn't make sense to me, space turfs have ambient light unconditionally now. is this issue outdated or is the description just wrong? is it just the same as #2090?

out-of-phaze avatar Jun 20 '24 08:06 out-of-phaze

Per Discord, space only generates corners when needed.

MistakeNot4892 avatar Jun 20 '24 12:06 MistakeNot4892