Damage, Oxyloss and welding glass overlays are not applied properly.

[Kaksisilma]

Description of issue

When you receive a lot of brute damage, a red overlay forms around your screen. Similarly, receiving too much oxygen damage causes your screen to become blacker, and putting on a welding helmet significantly obscures your vision.

Those are all what I am calling 'overlays'. They are not being applied at all in game. The oxygen damage overlay does not work, nor does the red, brute damage overlay. And putting on a welding helmet does not change your vision.

All of those overlays are available at 'icons/mob/screen_full.dmi'

Difference between expected and actual behavior

Overlays should be properly applied when the conditions are met.

Steps to reproduce

Deal yourself a lot of oxygen or brute damage, or wear a welding helmet. There will be no distortions on your screen view.

Specific information for locating

icons/mob/screen_full.dmi (Where the overlays are stored) code_onclick\hud\fullscreen.dm (Where some of the overlay code is stored.) code\modules\mob\living\carbon\human\life.dm - Line 671 (One of the mentions of the fire and brute damage overlay.)

Length of time in which bug has been known to occur

Since an unrelated test in a private server today, 10-30-2021.

Client version, Server revision & Game ID

Client Version: 513 Server Revision: 4a399c669ace3313da76725e724cd818650e8865 - Ahoy,-CMO.-I've-overdosed-on-fentanyl-and-now-I'm-going-to-die - 2021-10-30 Game ID: ceL-cyt8 Current map: ISEO Endeavour

AND

Client Version: 513 Server Revision: 69abc8611e64fccfb6da52435d92181b0be77f58 - ion - 2021-10-30 Game ID: ceL-c8zB Current map: Tradeship Ocelot Alpha

Issue bingo

• [x] Issue could be reproduced at least once
• [ ] Issue could be reproduced by different players
• [x] Issue could be reproduced in multiple rounds
• [x] Issue happened in a recent (less than 7 days ago) round
• [x] Couldn't find an existing issue about this

[MistakeNot4892]

Last I checked this they were being applied, but the scaling view was messing them up. Will brush off the fullscreen overlay PR I was working on and see if I can repro.

[MistakeNot4892]

Can confirm this is due to scaling:

You can see the edge of the scaled welding overlay on the right hand side.

[MistakeNot4892]

Scaling has been disabled, so this is now an inverted problem.