ecto_trail icon indicating copy to clipboard operation
ecto_trail copied to clipboard

PR to track downstream changes in a fork

Open AndrewDryga opened this issue 6 years ago • 5 comments

AndrewDryga avatar Dec 06 '18 03:12 AndrewDryga

Coverage Status

Coverage remained the same at 96.154% when pulling e179f9b3fcfe7fd2e9f0fb44cca207e2b633be1f on valiot:master into d6f69c89a4609d228591c79abc8988ec339f377a on Nebo15:master.

coveralls avatar Dec 08 '18 07:12 coveralls

Hello @AndrewDryga, at Valiot we are actively maintaining and adding features to ecto_trail as we are using it in our core product. If you like we can take over it. You can take a look at our fork here: https://github.com/valiot/ecto_trail/

We've also been thinking in renaming it so we can publish updated versions to hex.pm

What do you think?

acrogenesis avatar Jan 29 '19 00:01 acrogenesis

Hi @acrogenesis . Create PR with your changes and we can publish it

PavelVesnin avatar Feb 08 '19 19:02 PavelVesnin

I think it would be nice if we collaborate on improving it instead of maintaining two separate versions. I'm even totally okay to give you write access and rights to publish on Hex, if we agree to not introduce breaking changes (because it's used in our production too).

AndrewDryga avatar Feb 10 '19 11:02 AndrewDryga

Ebert has finished reviewing this Pull Request and has found:

  • 5 possible new issues (including those that may have been commented here).

But beware that this branch is 1 commit behind the Nebo15:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/Nebo15/ecto_trail/pulls/12.

AndrewDryga avatar Feb 20 '19 16:02 AndrewDryga