KISS icon indicating copy to clipboard operation
KISS copied to clipboard

disabled icons

Open marunjar opened this issue 1 year ago • 4 comments

grey out icons of disabled apps (#1265)

marunjar avatar Feb 13 '24 21:02 marunjar

I tested this on Nougat and ran into the following issue:

02-14 01:10:46.562 28995 29210 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #4
02-14 01:10:46.562 28995 29210 E AndroidRuntime: Process: fr.neamar.kiss, PID: 28995
02-14 01:10:46.562 28995 29210 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground()
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at android.os.AsyncTask$3.done(AsyncTask.java:325)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.FutureTask.run(FutureTask.java:242)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:761)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.graphics.drawable.Drawable.setColorFilter(android.graphics.ColorFilter)' on a null object reference
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at fr.neamar.kiss.utils.DrawableUtils.setDisabled(DrawableUtils.java:22)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at fr.neamar.kiss.result.AppResult.getDrawable(AppResult.java:53)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at fr.neamar.kiss.result.Result$AsyncSetImage.doInBackground(Result.java:42)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at android.os.AsyncTask$2.call(AsyncTask.java:305)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
02-14 01:10:46.562 28995 29210 E AndroidRuntime: 	... 4 more

syphyr avatar Feb 14 '24 00:02 syphyr

The fatal exception on Nougat is now fixed. Thanks.

syphyr avatar Mar 10 '24 19:03 syphyr

Thanks for rebase but this is still conflicting with https://github.com/Neamar/KISS/pull/2251/commits/3e05eb7af9317a164a78c3c5d864ca06b8dc2104

syphyr avatar Apr 01 '24 22:04 syphyr

Thanks for rebase but this is still conflicting with 3e05eb7

Will check when it's ready for merge. It should not matter for now, both PR are not ready yet.

marunjar avatar Apr 01 '24 23:04 marunjar