Icons are stuck as pebble shape

[KSPAtlas]

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

1. Use Meeyo icon theme (squircle)
2. See issue

Expected behavior Squircle shaped icons, should change when the setting is changed

Screenshots

Additional information

• App version: 3.16.5
• App installed via: (f-droid, Play Store, debug APK): F-Droid

Additional context Changing the icon shape via settings doesn't help

[licaon-kter]

Restart from Settings?

[marunjar]

Restart should work, but should not be necessary in my opinion. On change of settings favorites are simply not informed that something has changed: Thus icons are shown like before change.

Has anybody time to add a call of onFavoriteChange somehow on change of icons? https://github.com/Neamar/KISS/blob/53f8e88f76e584612e58bfcfab8c79ce2778b7b8/app/src/main/java/fr/neamar/kiss/IconsHandler.java#L80 https://github.com/Neamar/KISS/blob/e729c9db2d853268f1723881c4b30fa44841e6c9/app/src/main/java/fr/neamar/kiss/forwarder/Favorites.java#L120 I'm not sure what's the intended way of doing this, calling it directly or using broadcasts like e.g MainActivity.LOAD_OVER or MainActivity.FULL_LOAD_OVER

[KSPAtlas]

Restarting from settings didn't help

[KSPAtlas]

So the icons in the default pack respect the setting, bit the custom ones don't?

[KSPAtlas]

I checked with another icon pack, and Meeyo is the only one that has this. Does Meeyo have something special about it?

[licaon-kter]

You'd need to report to them I guess.

[marunjar]

Maybe icon pack providers a mask which is then applied. @KSPAtlas can you check if you can change shape of contact icons? There is a toggle for applying icon pack mask.

[KSPAtlas]

I can change contact icons, but also the icon pack isn't even pebble by default its meant to be squircle (which I want)

[marunjar]

I see, i'll try to fix this. I'd propose if shape is set to something else than "system default" this should simply override mask of icon pack.

But there's one caveat, if an icon from pack is smaller than chosen shape this this will lead to unwanted effects. Same if it's an iconpack with additional background and front image, if this is the case "system default" may be the only useful option.

[marunjar]

i tried to fix this with https://github.com/Neamar/KISS/pull/1846 so shape will be applied to all icons then. but i'm not sure if this will work out with meeyo icon pack because the icons have a size which fits in most other shapes you can use. For better understanding i have some screenshots, where the red background is for used shape:

• circle
• squircle
• random teardrops