KISS icon indicating copy to clipboard operation
KISS copied to clipboard

Since 3.16.4: No custom Icons working

Open patcomplus opened this issue 4 years ago • 9 comments

Sinc version 3.16.4, no custom Icons working on my Blackview 9800pro on Android 9. With 3.16.3 everything is fine. The icons turn into white squares or what ever shape they have and thats it. I use articons and tried other custom packs too, same problem. No I remain on the old version.

Thank you!

patcomplus avatar Nov 05 '21 07:11 patcomplus

/close as fixed in 3.16.5, pull to refresh and update your F-Droid index

licaon-kter avatar Nov 05 '21 08:11 licaon-kter

The problem is stil in the current version.

patcomplus avatar Nov 05 '21 09:11 patcomplus

Tried Arcticons both Dark and Light, no issue here for me with 3.16.5

Can you attach a picture?

licaon-kter avatar Nov 05 '21 09:11 licaon-kter

Screenshot_20211105111608 Screenshot_20211105111617

patcomplus avatar Nov 05 '21 10:11 patcomplus

Oh well arcticons light works... Strange.

patcomplus avatar Nov 05 '21 10:11 patcomplus

I think I got it. Several KISS restarts later, it works!

patcomplus avatar Nov 05 '21 10:11 patcomplus

i think got it: it looks like this is a pretty specific problem with arcticons dark and a little bit a side effect of #1802

You need a custom shape for icons, e.g. squircle Then you must use a icon pack with white lines with transparent background, these icons itself are not adaptive. And then there are some kiss settings which changes these icons.

  1. Settings > User Interface > Force icon background: the white lines are placed on white background, thats also reproducible on 3.16.3 and before
  2. Settings > User Interface > Force background shape: works similar as the other setting, for shaping icons also the white background is applied. Because of #1802 now also for icon packs, on 3.16.3 this setting was simply ignored.

@patcomplus @licaon-kter which settings have you use? can you confirm this behaviour?

i'm not sure how to solve this:

  1. should i revert to previous behaviour? then Force background shape from settings will then be ignored for icon packs
  2. should shape be applied to icons, but without white background? This also may have some unwanted effects
  3. should there be another background color used? primary color of kiss or a customizable one?
  4. do you have any other suggestions?

marunjar avatar Nov 05 '21 18:11 marunjar

Here my settings. With these, it works. Unfortunatly I dont know my steps to solve it, i tried for myself, some changes with the icon shapes, like you told, restarted KISS and well, thats it.

Hope that my settings helps.

I think pont 2 of your possible solutions would be the best.

{"__v":183,"force-shape":true,"history-hide":true,"gesture-left":"display-history","enable-suggestions-keyboard":true,"large-favorites-bar":true,"pref-rounded-list":true,"transparent-favorites":false,"pref-toggle-tags-list":["Nachrichten","Laden","Appcenter","Store","Appzentrale"],"theme":"semi-transparent-dark","theme-shadow":"enabled","theme-bar-color":"semi-dark","gesture-long-press":"display-menu","history-mode":"frequency","force-adaptive":false,"icons-pack":"com.donnnno.arcticons","pref-hide-search-bar-hint":true,"__tags":{"app://org.mozilla.firefox/org.mozilla.fenix.IntentReceiverActivity":"Internet Web Browser Netz Navigator","app://com.flir.tiger/com.flir.monarch.ui.library.LibraryActivity":"flir","app://com.fsck.k9/com.fsck.k9.activity.MessageList":"E-Mail Nachrichten Post Brief","app://com.android.contacts/com.android.contacts.activities.PeopleActivity":"Kontakte Leute Personen Beziehungen","app://com.android.deskclock/com.android.deskclock.DeskClock":"Uhr Alarm Timer Stoppuhr Wecker","app://com.android.vending/com.android.vending.AssetBrowserActivity":"Market Store App-Center Appcenter Anwendungen Appstore App-Store Laden Appzentrale App-Zentrale","app://com.google.android.apps.messaging/com.google.android.apps.messaging.ui.ConversationListActivity":"Textnachricht Nachrichten SMS MMS","app://com.android.dialer/com.android.dialer.app.DialtactsActivity":"anrufen wählen telefon"}}

patcomplus avatar Nov 08 '21 12:11 patcomplus

Hi! Just stumbled across this issue, and it reminded me of an issue that the trebuchet launcher from LineageOS has too: https://github.com/Donnnno/Arcticons/issues/127 https://gitlab.com/LineageOS/issues/android/-/issues/3326

Donnnno avatar Nov 09 '21 10:11 Donnnno