Clusterize.js icon indicating copy to clipboard operation
Clusterize.js copied to clipboard

scroll_elem = window

Open de-robat opened this issue 7 years ago • 2 comments

Upfront: Thx for this tool, it's really helpfull and saved me a lot of time!

I came across a strange behaviour today though. I tried setting the scroll_element to window for my use case today. Unfortunatley this does not work as expected. "this.scroll_elem.scrollTop" is going to be undefined in this scenario. The proper scrollPosition for the window is derived via

window.pageYOffset;

I'm wondering, whether im doing something wrong here? I'd be happy to create a Pull Request otherwise

de-robat avatar Apr 20 '17 14:04 de-robat

Check this PR https://github.com/NeXTs/Clusterize.js/pull/73

NeXTs avatar Apr 20 '17 17:04 NeXTs

Yep, this is a solution as well, Thx for ponting me to it. This Request is open since 9Months by now though. Any specific reasons why you dont wan't to merge it? (Besides it obviously has merge Conflicts by now :) )

de-robat avatar Apr 21 '17 12:04 de-robat