NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

VDV examples

Open skinkie opened this issue 6 months ago • 9 comments

So someone "broke" or at least "was able to spot issues" in the VDV examples.

https://github.com/NeTEx-CEN/NeTEx/actions/runs/15869257615/job/44741970679#step:6:215

skinkie avatar Jun 25 '25 07:06 skinkie

The error is coming from the a set of <RegistrationNumber/> They have to either contain a value, either just be removed There is now a _VehicleUnique_RegistrationNumber_constraint that does not allow this kind of empty RegistrationNumber

Aurige avatar Jun 30 '25 10:06 Aurige

But he corresponding https://github.com/NeTEx-CEN/NeTEx/pull/837 is quite old

Aurige avatar Jun 30 '25 10:06 Aurige

it looks that master is broken for 4 month (since https://github.com/NeTEx-CEN/NeTEx/pull/837 ) when no error was triggered ! The merge of https://github.com/NeTEx-CEN/NeTEx/pull/925 (comment update) to master, triggered a new validation that caught the error... Does this makes sense ?

Aurige avatar Jun 30 '25 16:06 Aurige

If that's the case, I'm not willing to correct examples in master, so the solution would be to revert https://github.com/NeTEx-CEN/NeTEx/pull/837 and migrate it to next.

Aurige avatar Jun 30 '25 16:06 Aurige

So you are not willing to do it. Because?

skinkie avatar Jun 30 '25 17:06 skinkie

Sure I can do it, but wanted first to make sure that this option was OK for the group

Aurige avatar Jul 01 '25 08:07 Aurige

@duexw to fix the VDV example with help if @Aurige if needed

Aurige avatar Jul 01 '25 12:07 Aurige

Fixed in my own clone duexw/NeTEx, but I currently do not have the access right to fix it in this repository. Also I observed that Altova XML Spy 2025 does not find the validation error unless you change the unique constraint to include the namespace of the element, e.g <xsd:field xpath="RegistrationNumber"/> to <xsd:field xpath="netex:RegistrationNumber"/>

duexw avatar Aug 21 '25 17:08 duexw

@duexw According to the settings you must be able to create a branch, and push that branch for a pull request.

skinkie avatar Aug 21 '25 18:08 skinkie